Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8720 - Update for srpski.lang (cause: 4 changed sources)

Attached to Project: Rockbox
Opened by Ivan Pesic (eevan) - Tuesday, 11 March 2008, 12:22 GMT+2
Last edited by Nils Wallménius (nls) - Saturday, 10 May 2008, 08:02 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I have made this diff using the http://rasher.dk/rockbox/translate/ webpage. The cause are 4 new source strings in English. Also, several strings for certain targets were accidentally left untranslated. It's also fixed now.



   srpski.diff (9 KiB)
This task depends upon

Closed by  Nils Wallménius (nls)
Saturday, 10 May 2008, 08:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed, thanks.
Comment by Ivan Pesic (eevan) - Tuesday, 11 March 2008, 15:15 GMT+2
I've noticed one error in the serbian.diff that I posted originally.

Here is corrected one.

   srpski.diff (9.1 KiB)
Comment by harry tu (bookshare) - Wednesday, 12 March 2008, 23:53 GMT+2
One thing that didn't get pointed out in the posting of the original .lang file was any string with an id of lang_sysfont_xxx (with xxx meaning anything) must be written with latin letters. Fix this, and it will be commitable.
Comment by Ivan Pesic (eevan) - Thursday, 13 March 2008, 00:03 GMT+2
OK, thanks for pointing this out! I'll fix it.
Is it ok to post here the complete fixed .lang file? I don't know which tool to use to make a .diff.
Comment by Ivan Pesic (eevan) - Thursday, 13 March 2008, 01:15 GMT+2
OK, thanks for pointing this out! I'll fix it.
Is it ok to post here the complete fixed .lang file? I don't know which tool to use to make a .diff.
Comment by Ivan Pesic (eevan) - Thursday, 13 March 2008, 01:42 GMT+2
Well, I've found diffutils for Windows and downloaded the latest SVN revision of srpski.lang (16616). I fixed all, started diff, and this is the result. I think that it should be ok now. I'm sorry for any inconvenience caused.
   srpski.diff (20.1 KiB)
Comment by Nils Wallménius (nls) - Thursday, 13 March 2008, 23:11 GMT+2
strings marked as deprecated should not have qoutes, you have several changes like:

- recording: deprecated
+ recording: "deprecated"

which while not really causing any trouble are unnecessary and incorrect.
Comment by Ivan Pesic (eevan) - Friday, 14 March 2008, 11:54 GMT+2
In my first translation, I haven't touched those strings, but .diff made by http://rasher.dk/rockbox/translate/ webpage included those changes, so I also included them.
I fixed that now.
Thanks for your comment!
Here is the (hopefully) final diff file :)
   srpski.diff (19.8 KiB)
Comment by harry tu (bookshare) - Saturday, 15 March 2008, 00:33 GMT+2
I like the sysfont stuff; you did it correctly.
Comment by Ivan Pesic (eevan) - Monday, 17 March 2008, 02:54 GMT+2
Added the very recent updates in english.lang from r16682 (two source strings are deprecated). diff is against the latest serbian lang in repository (16667)
   srpski.diff (21.3 KiB)
Comment by harry tu (bookshare) - Saturday, 10 May 2008, 03:19 GMT+2
This patch needs some serious updating. There are missing strings so I cannot do it.

Loading...