Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8721 - viewportify the button bar - needs input

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 11 March 2008, 12:25 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Thursday, 29 May 2008, 11:00 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To Jonathan Gordon (jdgordon)
Player Type All players
Severity Low
Priority High
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

this patch changes the button bar to draw in a viewport. the point of the patch was to remove the display dependancy on the BB (so lists wouldnt need to know if the BB is present or not when it chooses how high to draw...)

the problem i've hit is I cant think of a nice way to tell the viewport screens (well, just list) that the BB is to be drawn or not without affecting the "old" screens.

if someone can think of a good way to do it please comment...
   buttonbar.vp.diff (5.4 KiB) 
 apps/screen_access.c |    3 --
 apps/screen_access.h |   14 -------------
 apps/gui/buttonbar.c |   54 ++++++++++++++++++++++++++-------------------------
 apps/menu.c          |    2 -
 4 files changed, 29 insertions(+), 44 deletions(-)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Thursday, 29 May 2008, 11:00 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  partially accepted... the BB is now drawn in its viewport, but there is still a dependancy on the screens struct
Comment by Justin Hannigan (Chronon) - Thursday, 17 April 2008, 20:41 GMT+2
Can you clarify what is meant by "button bar"? Is that another term for the status bar?

Loading...