Rockbox

Tasklist

FS#8790 - Exit battery debug menu with standard context cancel button

Attached to Project: Rockbox
Opened by Bertrik Sikken (bertrik) - Sunday, 23 March 2008, 18:07 GMT
Last edited by Bertrik Sikken (bertrik) - Tuesday, 22 April 2008, 19:10 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

All debug menus on my sansa e260 can be exited by a left-button press, except the battery menu. This patch fixes that to make it behave like the other debug menus.
This task depends upon

Closed by  Bertrik Sikken (bertrik)
Tuesday, 22 April 2008, 19:10 GMT
Reason for closing:  Accepted
Additional comments about closing:  Initial patch committed. Second part skipped as discussed in my last comment.
Comment by Bertrik Sikken (bertrik) - Wednesday, 26 March 2008, 19:08 GMT
This patch goes a little further and replaces all lines like
if (button_get_w_tmo(HZ/10) == (DEBUG_CANCEL|BUTTON_REL))
with line
if (get_action(CONTEXT_STD,HZ/10) == ACTION_STD_CANCEL)

This actually makes the code smaller because it allows the removal of locally defined model specific #defines for DEBUG_CANCEL.
Comment by Bertrik Sikken (bertrik) - Tuesday, 15 April 2008, 19:46 GMT
resynced to 17123
Comment by Bertrik Sikken (bertrik) - Saturday, 19 April 2008, 17:52 GMT
I think I'll commit the original patch and hold off the more elaborate change because that doesn't really fix a reported bug and may break something for another target (which I cannot test).

Loading...