FS#8836 - Short pcmbuf_beep() (AKA Keyclick) doesn't work properly on PortalPlayer targets
Opened by Steve Bavin (pondlife) - Tuesday, 01 April 2008, 10:51 GMT
Last edited by Steve Bavin (pondlife) - Thursday, 11 December 2008, 08:10 GMT
The attached patch revises pcmbuf_beep() in an attempt to kill the beeeeep of death that occurs on PortalPlayer targets when keyclick is enabled.
With this patch, on c200, the unpleasent beep seems to have gone, but the keyclick isn't very reliable:
- Before playback is started, the keyclick has an extra click (probably when pcm playback begins)
- While playback is in progress, the keyclick sounds correct, but is delayed (could the 1/8th second delay be removed?)
- After playback then STOP, the very first keyclick works, but subsequent ones are almost inaudible.
I've no idea why, but if the un-needed "memset(bufstart, 0, samples * 4);" is removed, then the keyclick after playback rarely sounds at all. I guess it's something to do with memory caching, but am not a low-level expert.
Also, it would be good if the pcmbuf static variable audiobuffer could be renamed, to avoid potential confusion with the audiobuffer declared in buffer.c.
Thursday, 11 December 2008, 08:10 GMT
Reason for closing: Fixed
Additional comments about closing: No need to disable the option now. Thanks, jhMikeS!