Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8865 - timer plugin

Attached to Project: Rockbox
Opened by x (vmh) - Thursday, 10 April 2008, 22:40 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Saturday, 04 June 2011, 23:39 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This is a timer plugin. After the set time the plugin stops the music and plays a tone until the user presses a button to stop the alarm.

Most of the code is copied from battery_bench.c and test_sampr.c
   timer.patch (8.5 KiB) 
 apps/plugins/timer.c    |  226 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 apps/plugins/CATEGORIES |    1 
 apps/plugin.h           |    3 
 apps/plugin.c           |    3 
 5 files changed, 232 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Saturday, 04 June 2011, 23:39 GMT+2
Reason for closing:  Out of Date
Comment by alex wallis (alexwallis646) - Friday, 11 April 2008, 05:04 GMT+2
Hi. Just wondering what practical reasons would a person want to use this timer for? I mean if you need it you have the sleep timer for example. Maybe i'm just being dim, but I can't see any real reason for using it. apart from maybe if you work out in a jim, and even then they usually provide there own music don't they? plus if the player is an hd player, i should think it wouldn't be good to be moved around like it would in a jim.
Comment by Linus Nielsen Feltzing (linusnielsen) - Friday, 11 April 2008, 08:58 GMT+2
I can think of a few more uses, like a kitchen timer (egg boiling, cake baking etc), not only in the gym.
Comment by Linus Nielsen Feltzing (linusnielsen) - Friday, 11 April 2008, 09:28 GMT+2
I'm not sure why you use the sleep timer for this. Wouldn't it be easier to just count ticks in the TSR thread?
Comment by PaulJam (PaulJam) - Friday, 11 April 2008, 10:42 GMT+2
I think it is a good idea to use the sleep timer. This way you see the remaining time in the WPS (if the WPS supports that).
Comment by Linus Nielsen Feltzing (linusnielsen) - Friday, 11 April 2008, 12:06 GMT+2
I think it's a bad idea, since the sleep timer is totally unrelated.
Comment by x (vmh) - Friday, 11 April 2008, 20:20 GMT+2
@alexwallis646
I have a long travel to work. I use it, so I won't miss the right station to get off the train :)

@linusnielsen
Maybe it's more appropriate to count the ticks or using the timer provided by the api, but as PaulJam said, it would need more code to display the remaining time or to adjust the time.

update:
- fixed: loading another plugin won't show the dialog if timer has finished
- fixed: fully controllable via remote-control
   timer.patch (8.6 KiB) 
 apps/plugins/timer.c    |  234 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 apps/plugins/CATEGORIES |    1 
 apps/plugin.h           |    3 
 apps/plugin.c           |    3 
 5 files changed, 240 insertions(+), 2 deletions(-)

Comment by x (vmh) - Friday, 18 April 2008, 22:09 GMT+2
changed alarm tone and other small changes
   timer.patch (9.2 KiB) 
 apps/plugins/timer.c    |  245 ++++++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/SOURCES    |    1 
 apps/plugins/CATEGORIES |    1 
 apps/plugin.h           |    3 
 apps/plugin.c           |    3 
 5 files changed, 251 insertions(+), 2 deletions(-)

Comment by Vladimir Homutov (VL) - Saturday, 20 June 2009, 01:09 GMT+2
Updated plugin to work with latest rockbox (rev 21354, 20 June 2009)

- works with new plugin API (http://svn.rockbox.org/viewvc.cgi?view=rev&revision=19776)
- removed SIMULATOR ifdefs - i found no problems with this plugin in simulator
- tested (a little) on iriver H340 - looks like it works
   timer_newapi.patch (9.7 KiB) 
 rockbox/apps/plugin.c            |    3 
 rockbox/apps/plugin.h            |    3 
 rockbox/apps/plugins/CATEGORIES  |    1 
 rockbox/apps/plugins/SOURCES     |    1 
 rockbox/apps/plugins/SOURCES.rej |   16 ++
 rockbox/apps/plugins/timer.c     |  238 +++++++++++++++++++++++++++++++++++++++
 6 files changed, 261 insertions(+), 1 deletion(-)

Comment by Vladimir Homutov (VL) - Saturday, 20 June 2009, 01:11 GMT+2
oops, previous patch contains junk file, fixing
   timer_newapi.patch (9.1 KiB) 
 rockbox/apps/plugin.c           |    3 
 rockbox/apps/plugin.h           |    3 
 rockbox/apps/plugins/CATEGORIES |    1 
 rockbox/apps/plugins/SOURCES    |    1 
 rockbox/apps/plugins/timer.c    |  238 ++++++++++++++++++++++++++++++++++++++++
 5 files changed, 245 insertions(+), 1 deletion(-)

Comment by Rosso Maltese (asettico) - Saturday, 17 October 2009, 10:54 GMT+2
Sync to r23221.
   plugins-8865timer_newapi.0.patch (9 KiB) 
 apps/plugins/CATEGORIES |    1 
 apps/plugins/SOURCES    |    1 
 apps/plugin.c           |    3 
 apps/plugin.h           |    3 
 apps/plugins/timer.c    |  238 ++++++++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 245 insertions(+), 1 deletion(-)

Loading...