Rockbox

Tasklist

FS#8895 - rec button: - Go to fm radio

Attached to Project: Rockbox
Opened by Daniel Dalton (ddalton) - Tuesday, 15 April 2008, 08:35 GMT
Last edited by Jonathan Gordon (jdgordon) - Sunday, 06 June 2010, 11:48 GMT
Task Type Patches
Category FM Tuner
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Ok, this patch just allows a short press of the rec button on h300 and h100 to go to the radio.
I didn't remove any keymaps so I think this should be ok to commit. Even though most developers don't like keymap patches.

Todo:
- Check white space including new lines...
- Add more keymaps for more players
- Testing!

I think that is it.
With white space I was in a bit of a rush and couldn't check it...

Also, it applies on the latest rev, but not tested.
I tested on something like 600 revs ago or something...

Here it is...I don't have a lot of time for rockbox at the minute, otherwise I would do some more testing.
I have been using this patch for over 2 months and it has worked great for me.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 06 June 2010, 11:48 GMT
Reason for closing:  Rejected
Additional comments about closing:  use the hotkeys system to do this (in a new patch)
Comment by Steve Bavin (pondlife) - Tuesday, 15 April 2008, 08:42 GMT
Erm, short REC is already used to prevent USB connection (and clear settings), on H300 at least.
Comment by Daniel Dalton (ddalton) - Tuesday, 15 April 2008, 21:52 GMT
Well does clearing settings still work? Please test. Here is the file... Lynx didn't upload it. Also I will think of something for the usb stuff...
Comment by Steve Bavin (pondlife) - Wednesday, 16 April 2008, 05:55 GMT
I think there's a motion to use the HOLD button for USB charging. http://www.rockbox.org/tracker/task/8702 might be the request.
Comment by Daniel Dalton (ddalton) - Wednesday, 16 April 2008, 06:48 GMT






>I think there's a motion to use the HOLD button for USB charging.

Ok, but what are you saying? Switching to hold when plugging in the usb cable does what you said short rec did? So what do I need to fix in my patch? If I still need to fix usb will the following solution work?
- Change togle from preset to scan in fm radio to short rec
- Then use long play from anywhere for usb...

Will that work? Oh and does settings_clear work as you said with rec when starting rockbox?

Thanks for looking at this.
Comment by Daniel Dalton (ddalton) - Wednesday, 16 April 2008, 06:55 GMT


Ok pondlife: I had a quick look in the keymap file, no mention of usb, but his output of grep for 'BUTTON_REC'
I think everything should be ok, I should really test bookmarks.
Here is the output anyway:

daniel@debian-compaq:/media/daniel-external/svn/rockbox/trunk/apps/keymaps$ grep 'BUTTON_REC' -n keymap-h1x0_h3x0.c 64: { ACTION_STD_REC, BUTTON_REC|BUTTON_REPEAT, BUTTON_NONE }, 92: { ACTION_WPS_REC, BUTTON_REC|BUTTON_REPEAT, BUTTON_NONE }, 194: { ACTION_BMS_DELETE, BUTTON_REC, BUTTON_NONE }, 237: { ACTION_REC_NEWFILE, BUTTON_REC, BUTTON_NONE }, 259: { ACTION_KBD_BACKSPACE, BUTTON_REC, BUTTON_NONE }, 260: { ACTION_KBD_BACKSPACE, BUTTON_REC|BUTTON_REPEAT, BUTTON_NONE },
Comment by Daniel Dalton (ddalton) - Wednesday, 16 April 2008, 06:56 GMT

Its all over the place... Attached output if that makes it easier to view...
Thanks.
   grep.txt (0.5 KiB)

Loading...