Rockbox

Tasklist

FS#8940 - Save dynamic playlist in playlist catalog directory by default

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Sunday, 27 April 2008, 04:29 GMT
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 20 July 2011, 14:16 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

When saving a dynamic playlist, the proposed name (given as a starting
point for kbd_input) is "/dynamic.m3u8".

I normally want to save my playlists in the Playlists directory, where
the playlist catalog can find them. So unless I'm missing something, it
would be much more convenient to suggest "/Playlists/dynamic.m3u8" for a
default playlist filename. And actually /Playlists should be the
configured playlist catalog directory ("playlist catalog directory"
setting). (It's useful to change this to avoid the hidden folder on the
e200.) The attached patch does this.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 20 July 2011, 14:16 GMT
Reason for closing:  Out of Date
Comment by Paul Louden (Llorean) - Sunday, 27 April 2008, 06:36 GMT
Many of us don't have a /Playlists folder, nor want to create one. This creates exactly the opposite problem for us: We'd have to delete more of the string every single time we used it. You're just forcing a problem for one group of people off onto another group of people.
Comment by Jacob Brooks (jac0b) - Sunday, 27 April 2008, 13:30 GMT
I think this patch already does that, and it will check if you a Playlists directory and if you don't it will create it.

http://www.rockbox.org/tracker/task/7542
Comment by Stephane Doyon (sdoyon) - Monday, 28 April 2008, 01:05 GMT
Llorean wrote:

>Many of us don't have a /Playlists folder, nor want to create one. This
>creates exactly the opposite problem for us: We'd have to delete more
>of the string every single time we used it. You're just forcing a
>problem for one group of people off onto another group of people.

But then you could just set your playlist catalog directory setting to "/", no?
Comment by Paul Louden (Llorean) - Monday, 28 April 2008, 01:38 GMT
Where is this option you speak of? It's not described in the manual (which says all playlists in the playlist catalog go into /Playlists) nor can I seem to find an option for it in my own browsings.
Comment by Thomas Martitz (kugel.) - Monday, 28 April 2008, 12:02 GMT
It's part of his request...

"And actually /Playlists should be the configured playlist catalog directory ("playlist catalog directory"setting)."
Comment by Paul Louden (Llorean) - Monday, 28 April 2008, 12:08 GMT
I don't see the request as requesting to add that, but rather mentioning use of it.

But as it stands, I'd rather not have my playlist catalog folder tied in any way to where my playlists save by default. Currently I use the catalog AND I use playlist scattered throughout my player. If a setting were added, it should be exclusively for a string to add to the path when saving dynamic playlists, in my opinion.
Comment by Stephane Doyon (sdoyon) - Monday, 28 April 2008, 13:06 GMT
The "playlist catalog directory" setting was added in r16181,r16195.
By jdgordon. It appears to still be undocumented. There previously was an
implementation using a special config file.

I found this setting useful to workaround the issue with the /Playlists
folder on e200. It does require you to edit your config.cfg with an
editor.

It seems I may have confused the issue by phrasing this like a request:
this is actually a patch, and a pretty small one.

All this patch does is prepend that setting to the default dynamic
playlist filename suggested for the kbd_input() when saving a dynamic
playlist. It applies only when the playlist is still unnamed.

Correction to my earlier comment: if you want your dynamic playlists in
the root, you probably want to set "playlist catalog directory" to "", so
the path concatenation works right.
Comment by Paul Louden (Llorean) - Monday, 28 April 2008, 13:08 GMT
But this would make it impossible to have my dynamic playlists default to the root, but my playlist catalog still be in the catalog folder.
Comment by Stephane Doyon (sdoyon) - Tuesday, 29 April 2008, 13:09 GMT
Llorean wrote:
>But this would make it impossible to have my dynamic playlists default
>to the root, but my playlist catalog still be in the catalog folder.

True.

Erm that's not what you had asked for initially :-). So you want
playlist catalog functions on the /Playlists directory, but saves to
go in the root by default? That seems less convenient and less
intuitive to me. A stronger argument is that pecking out /Playlists in
the virtual keyboard is quite a bit more work than deleting said
string.

Well the only way I can see to make us both happy is to introduce a
separate setting for default dynamic playlist save location. But then
someone will complain that this is too fine a point to justify adding
yet another setting...
Comment by Paul Louden (Llorean) - Thursday, 01 May 2008, 09:08 GMT
What I asked for initially was because there was an undocumented feature. What I've asked for now is not mutually exclusive in any way with what I wanted to ask for initially, so I don't see why you think it's at all relevant. To be specific, what I want is "any change should not remove the possibility of using it as you can currently use it." CURRENTLY the playlist catalog defaults to /Playlists while the save folder is /, so this needs to be something that can be reproduced with whatever change happens.

This is especially useful in units with removable storage where you may want all playlists for the storage card to be saved on the card, while you want to keep "local" playlists in the catalog folder or on the internal storage somewhere else.

Loading...