Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8959 - Quick voice some status info from quickscreen

Attached to Project: Rockbox
Opened by Stephane Doyon (sdoyon) - Sunday, 04 May 2008, 17:55 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 11 January 2012, 13:56 GMT+2
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The two most important items from the status bar that blind users are
missing out on are the time (clock) and battery level. These can be
spoken from the Rockbox info menu, but that requires far too many
keypresses.

This patch adds an action to speak the time on SELECT and the battery
level on LONG SELECT from within the quickscreen (and it also exits the
quickscreen automatically).
   quickinfo.diff (1.6 KiB) 
 trunk/apps/gui/quickscreen.c |   26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 11 January 2012, 13:56 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  use the shortcuts menu for this now
Comment by Tuukka Ojala (tuojal) - Sunday, 04 May 2008, 21:29 GMT+2
Big thanks Stephane! Finally we have a good and pretty fast way to check the time.
Comment by Claudio Capriati (claudiocpr) - Tuesday, 06 May 2008, 14:17 GMT+2
Hi Stephane,
good work! but i found a bug: when you are in the quick screen, if you use right button it says time clock and closes quickscreen instead to change repeat mode value.
greetings
Comment by Stephane Doyon (sdoyon) - Tuesday, 06 May 2008, 15:04 GMT+2
Claudio Capriati wrote:
>good work! but i found a bug: when you are in the quick screen, if you
>use right button it says time clock and closes quickscreen instead to
>change repeat mode value.

Oh... I had tested on X5. You have an e200 I believe and I hadn't tried
it yet. Yes I see the keymaps have QS_RIGHT on release and OK on RIGHT
press... Ah well I thought I could get away with not modifying all the
15-20 keymaps, at least for the first prototype for this idea, by reusing
the standard context actions... But it seems that was too much of a
shortcut.

Sorry about that, I'll fix. There may be several days delay as I'll
probably be off the net for a week or so.

Thanks for trying this out.
Comment by Stephane Doyon (sdoyon) - Tuesday, 03 June 2008, 04:24 GMT+2
OK, this new patch should fix the problem.
   quickinfo.diff (12 KiB) 
 trunk/apps/gui/quickscreen.c            |   33 ++++++++++++++++++++++++++++++++
 trunk/apps/action.h                     |    4 +++
 trunk/apps/keymaps/keymap-e200.c        |    8 ++++++-
 trunk/apps/keymaps/keymap-x5.c          |    3 ++
 trunk/apps/keymaps/keymap-c200.c        |    7 ++++++
 trunk/apps/keymaps/keymap-creativezv.c  |    4 +++
 trunk/apps/keymaps/keymap-creativezvm.c |    4 +++
 trunk/apps/keymaps/keymap-gigabeat-s.c  |    3 ++
 trunk/apps/keymaps/keymap-gigabeat.c    |    3 ++
 trunk/apps/keymaps/keymap-h1x0_h3x0.c   |    3 ++
 trunk/apps/keymaps/keymap-ifp7xx.c      |    5 +++-
 trunk/apps/keymaps/keymap-ipod.c        |    7 ++++++
 trunk/apps/keymaps/keymap-m200.c        |    3 ++
 trunk/apps/keymaps/keymap-mr100.c       |    3 ++
 trunk/apps/keymaps/keymap-sa9200.c      |    3 ++
 15 files changed, 91 insertions(+), 2 deletions(-)

Comment by Daniel Dalton (ddalton) - Saturday, 14 June 2008, 02:58 GMT+2
Nice job, I remember your last one you mailed me with a whole new quick screen. I think this is the best way of keeping the old quickscreen, but adding features we want. just 2 questions:

1. ACTION_QS_VOLUP is never called on the h300 (from what I can tell): I grepped your patch and the keymap file with your patch applied. I also did a quick test on the sim. So was the problem just that there was not enough buttons? Or could we me long up do volup and long down do voldown? Or is this a messy approach, I think it would be...
2.
+bool gui_quickscreen_do_quickinfo(int button) +{ + if(!global_settings.talk_menu) + return false; + switch(button) {
Does the above code make select and long select (so time and battery level) be available if talk_menu is enabled. Sorry about no line breaks in the code dunno whats going on with brltty's cut and paste...

Thanks.
Comment by Stephane Doyon (sdoyon) - Tuesday, 17 June 2008, 06:22 GMT+2
Daniel Dalton wrote:

>So was the problem just that there
>was not enough buttons?

yep.

>Or could we me long up do volup and long down
>do voldown? Or is this a messy approach, I think it would be...

It wouldn't work well. And those are actually already mapped.

>Does the above code make select and long select (so time and battery
>level) be available if talk_menu is enabled.

Erm... If I understand the question correctly: yes.

A side effect being that SELECT won't take you out of the quickscreen
if talking menus are not enabled.
Comment by Daniel Dalton (ddalton) - Wednesday, 18 June 2008, 12:56 GMT+2
Stephane Doyon wrote:

>>Does the above code make select and long select (so time and battery
>>level) be available if talk_menu is enabled.
>Erm... If I understand the question correctly: yes.

So basically if talk_menu is off select (long and short) will do
nothing?

>A side effect being that SELECT won't take you out of the quickscreen
>if talking menus are not enabled.

Yes, but you could always just hit menu again (AB) on h300...

Nice patch though.

Loading...