Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8965 - WPS tag for showing skip length

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Monday, 05 May 2008, 21:46 GMT+2
Last edited by Alexander Levin (fml2) - Monday, 22 June 2009, 22:48 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Introduce a new WPS tag (%ms) which indicates whether te study mode is activated.
   wps_tag_study_mode.patch (2.4 KiB) 
 apps/gui/gwps-common.c       |    7 +++++++
 apps/gui/gwps.h              |    1 +
 apps/gui/wps_parser.c        |    1 +
 manual/appendix/wps_tags.tex |   10 +++++++++-
 4 files changed, 18 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Alexander Levin (fml2)
Monday, 22 June 2009, 22:48 GMT+2
Reason for closing:  Rejected
Additional comments about closing:  This became unnecessary after r19357 (generic setting tag) has been committed.
Comment by Marc Guay (Marc_Guay) - Monday, 05 May 2008, 21:49 GMT+2
Reminder: If/when this is committed add a note to the CustomWPS wiki page.
Comment by Stephane Doyon (sdoyon) - Tuesday, 06 May 2008, 01:29 GMT+2
Thanks for doing this.
Comment by Alexander Levin (fml2) - Friday, 18 July 2008, 22:22 GMT+2
Here is an update: %ms, if used 'naked', now displays the skip length in minutes or zero if it's set to 'track.' It can also be used in a conditional. The first branch is for 'track', the other are for the appropriate number of minutes.

Example:
%ms

-- or

%?ms<Track|%ms>

-- or

%?ms<Track|One|Two|Three|Four|Five|Six (etc) >

I've also fixed the issue that the string value produced by the naked option was 1-based instead of 0-based (as described in the manual/wiki) -- also for some other tags. Sorry for not providing a separate patch.

Feedback is welcome.
   wps_tag_study_mode.patch (2.4 KiB) 
 apps/gui/gwps-common.c       |    7 +++++++
 apps/gui/gwps.h              |    1 +
 apps/gui/wps_parser.c        |    1 +
 manual/appendix/wps_tags.tex |   10 +++++++++-
 4 files changed, 18 insertions(+), 1 deletion(-)

Comment by Alexander Levin (fml2) - Friday, 18 July 2008, 22:30 GMT+2
Now with the correct patch (thanks to PaulJam :-)
   wps_skip_length.patch (4.6 KiB) 
 apps/gui/gwps-common.c       |   34 +++++++++++++++++++++-------------
 apps/gui/gwps.h              |    1 +
 apps/gui/wps_parser.c        |    1 +
 apps/settings.h              |    2 +-
 manual/appendix/wps_tags.tex |   10 +++++++++-
 5 files changed, 33 insertions(+), 15 deletions(-)

Loading...