Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#8989 - start of rec trigger settings -> viewport

Attached to Project: Rockbox
Opened by Jonathan Gordon (jdgordon) - Tuesday, 13 May 2008, 12:35 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Wednesday, 28 May 2008, 13:02 GMT+2
Task Type Patches
Category Recording
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

the plan for this patch was to change the rec trigger settings screen to not use inline settings... ideally to show the menu and optoins in a VP at the top of the screen and have a 2nd vp for the peak meters at the bottom...
I unfortunatly finished the top bit before realsing the peakmeters wouldnt be updated :(

so im putting this here in the hope someone comes up woth a solution
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Wednesday, 28 May 2008, 13:02 GMT+2
Reason for closing:  Accepted
Comment by Jonathan Gordon (jdgordon) - Tuesday, 13 May 2008, 17:15 GMT+2
so, this isnt as good as I was planning, but it still saves about 1.3k on the rec build...

2 line settings, the top line has an icon so it should be workable.

NOTE: this version doesnt talk, need to put that back in...
   rectrigger.diff (20.4 KiB) 
 apps/recorder/recording.c   |   25 +++-
 apps/lang/english.lang      |   17 +++
 apps/gui/option_select.c    |   23 +++-
 apps/settings.h             |   25 +++-
 apps/menus/recording_menu.c |  244 +++++++++++++++++++++++++++++++++++++++++++-
 apps/settings_list.c        |   59 +++++-----
 apps/sound_menu.h           |    2 
 7 files changed, 347 insertions(+), 48 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Thursday, 15 May 2008, 09:24 GMT+2
new version.. should actually work now and buttons are hopefully better, attached is the full zip for h120
   rockbox.h120.zip (1.86 MiB)
   rectrigger.1.diff (27.4 KiB) 
 apps/action.h                   |    1 
 apps/recorder/peakmeter.h       |    3 
 apps/recorder/recording.c       |   56 +++-----
 apps/recorder/peakmeter.c       |    5 
 apps/lang/english.lang          |   17 ++
 apps/settings.h                 |   25 ++--
 apps/menus/recording_menu.c     |  250 +++++++++++++++++++++++++++++++++++++++-
 apps/settings_list.c            |   59 ++++-----
 apps/sound_menu.h               |    2 
 apps/keymaps/keymap-cowond2.c   |    1 
 apps/keymaps/keymap-m3.c        |    1 
 apps/keymaps/keymap-h1x0_h3x0.c |    1 
 apps/keymaps/keymap-h10.c       |    1 
 apps/keymaps/keymap-ipod.c      |    1 
 apps/keymaps/keymap-x5.c        |    1 
 apps/keymaps/keymap-c200.c      |    3 
 apps/keymaps/keymap-recorder.c  |    1 
 apps/keymaps/keymap-e200.c      |    1 
 apps/keymaps/keymap-ondio.c     |    1 
 19 files changed, 353 insertions(+), 77 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Wednesday, 21 May 2008, 09:54 GMT+2
new version.. talks goodly.
   rectrigger.2.diff (28.2 KiB) 
 apps/action.h                   |    1 
 apps/recorder/peakmeter.h       |    3 
 apps/recorder/recording.c       |   56 +++-----
 apps/recorder/peakmeter.c       |    5 
 apps/lang/english.lang          |   17 ++
 apps/settings.h                 |   25 ++-
 apps/menus/recording_menu.c     |  270 +++++++++++++++++++++++++++++++++++++++-
 apps/settings_list.c            |   59 ++++----
 apps/sound_menu.h               |    2 
 apps/keymaps/keymap-cowond2.c   |    1 
 apps/keymaps/keymap-m3.c        |    1 
 apps/keymaps/keymap-h1x0_h3x0.c |    1 
 apps/keymaps/keymap-h10.c       |    1 
 apps/keymaps/keymap-ipod.c      |    1 
 apps/keymaps/keymap-x5.c        |    1 
 apps/keymaps/keymap-c200.c      |    3 
 apps/keymaps/keymap-recorder.c  |    1 
 apps/keymaps/keymap-e200.c      |    1 
 apps/keymaps/keymap-ondio.c     |    1 
 19 files changed, 373 insertions(+), 77 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Wednesday, 21 May 2008, 16:07 GMT+2
hoipefully final version... commiting in a day or two unless anyone comments...
If the only negative against this patch is the 2 line settings then IMO thats not a big enough deal to hold this out. major issues fixed here is no need to keep setting values in sync in multiple places, should give a big green delta, no more abusing a setting, etc
   rectrigger.3.diff (42.6 KiB) 
 apps/action.h                   |    1 
 apps/recorder/peakmeter.h       |    3 
 apps/recorder/recording.c       |   56 +--
 apps/recorder/peakmeter.c       |    5 
 apps/lang/english.lang          |   17 +
 apps/gui/option_select.c        |   11 
 apps/gui/option_select.h        |    4 
 apps/gui/quickscreen.c          |   17 -
 apps/settings.h                 |   25 +
 apps/menus/recording_menu.c     |  566 ++++++++++------------------------------
 apps/settings_list.c            |   59 ++--
 apps/sound_menu.h               |    2 
 apps/keymaps/keymap-cowond2.c   |    1 
 apps/keymaps/keymap-m3.c        |    1 
 apps/keymaps/keymap-h1x0_h3x0.c |    1 
 apps/keymaps/keymap-h10.c       |    1 
 apps/keymaps/keymap-ipod.c      |    1 
 apps/keymaps/keymap-x5.c        |    1 
 apps/keymaps/keymap-c200.c      |    3 
 apps/keymaps/keymap-recorder.c  |    1 
 apps/keymaps/keymap-e200.c      |    1 
 apps/keymaps/keymap-ondio.c     |    1 
 22 files changed, 263 insertions(+), 515 deletions(-)

Comment by Marianne Arnold (pixelma) - Thursday, 22 May 2008, 00:24 GMT+2
The last patch does not compile for my OndioFM (with or without the "changes" for the backlight mod). Building fails with

/1_builds/ondiofm/apps/menus/recording_menu.o: In function `_rectrigger':
recording_menu.c:(.text+0x538): undefined reference to `_option_select_next_val'

However it builds for M5 and c200. Tried to play around with it and it seems to do something on M5 (and the trigger indicator showed correctly different behaviour when changing the thresholds for example but I didn't have enough experience with triggered recording and some handy recording equipment to test more.
Comment by Jonathan Gordon (jdgordon) - Thursday, 22 May 2008, 00:38 GMT+2
ondio is missing quickscreen which currently that function isnt compiled for, that'll be fixed

Loading...