Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9000 - further mpc optimization for PP5020/24 and iaudio m5/x5

Attached to Project: Rockbox
Opened by Andree Buschmann (Buschel) - Friday, 16 May 2008, 21:54 GMT+2
Last edited by Andree Buschmann (Buschel) - Saturday, 17 May 2008, 13:11 GMT+2
Task Type Patches
Category Codecs
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

1. Use iram for calc_new_V() which is part of the synthesis filter.
2. Minor resorting within calc_new_V() reduces binsize a bit.

Speeds up +3% on PP5022. Effect on coldfire is not measured yet.
   mpc_opt_v01.patch (13.8 KiB) 
 apps/codecs/libmusepack/decoder.h      |    2 
 apps/codecs/libmusepack/synth_filter.c |  196 ++++++++++++---------------------
 apps/codecs/libmusepack/musepack.h     |    1 
 3 files changed, 76 insertions(+), 123 deletions(-)

This task depends upon

Closed by  Andree Buschmann (Buschel)
Saturday, 17 May 2008, 13:11 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  committed with r17552
Comment by Andree Buschmann (Buschel) - Saturday, 17 May 2008, 09:28 GMT+2
The above patch shouldn't compile for other targets than PP5022/24 or m5/x5 -- will be fixed later.
amiconn measured slow down on coldfire through the resorting within calc_new_V(). A new patch for testing on ICODE_ATTR will be placed here soon.
Comment by Andree Buschmann (Buschel) - Saturday, 17 May 2008, 12:57 GMT+2
Final version after some test in IRC by amiconn. ICODE_ATTR is set for calc_new_V() for PP5022/24 only. Other targets either haven't enough IRAM or the decoder performance suffers.
   mpc_opt_v02.patch (2 KiB) 
 apps/codecs/libmusepack/decoder.h      |    2 +-
 apps/codecs/libmusepack/synth_filter.c |    8 ++++++--
 apps/codecs/libmusepack/musepack.h     |   10 ++++++++++
 3 files changed, 17 insertions(+), 3 deletions(-)

Loading...