This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9021 - HAVE_RECORDING bug
Attached to Project:
Rockbox
Opened by James Vasile (vasile) - Wednesday, 21 May 2008, 16:47 GMT+1
Last edited by Peter D'Hoye (petur) - Sunday, 25 May 2008, 23:19 GMT+1
Opened by James Vasile (vasile) - Wednesday, 21 May 2008, 16:47 GMT+1
Last edited by Peter D'Hoye (petur) - Sunday, 25 May 2008, 23:19 GMT+1
|
DetailsTried to send this to the dev list, but it seems not to have gone through:
I downloaded the daily build of Rockbox yesterday for my video ipod. Today I decided to recompile without the audio recording features (I don't have a mic on this ipod). When I commented out the line defining HAVE_RECORDING, it wouldn't compile without the attached patch because SOUND_LEFT_GAIN, SOUND_RIGHT_GAIN and SOUND_MIC_GAIN only get defined in firmware/export/audiohw.h if HAVE_RECORDING is defined. In order for HAVE_RECORDING to work properly, that value needs to be tested in wm8758.c as it is in, say, wm8731.c. I haven't gotten very deep in the code, but casual inspection suggests as3514.c and other some others might suffer from the same defect. The one file patched below was the only one I needed to change for this target. |
This task depends upon
Closed by Peter D'Hoye (petur)
Sunday, 25 May 2008, 23:19 GMT+1
Reason for closing: Accepted
Additional comments about closing: thanks and welcome to the credits list ;)
Sunday, 25 May 2008, 23:19 GMT+1
Reason for closing: Accepted
Additional comments about closing: thanks and welcome to the credits list ;)