Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9067 - [GSoC] Accessibility and localization improvements

Attached to Project: Rockbox
Opened by Tom Ross (midgey34) - Tuesday, 03 June 2008, 08:41 GMT+1
Last edited by Tom Ross (midgey34) - Wednesday, 13 August 2008, 08:41 GMT+1
Task Type Patches
Category Applications
Status New
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This tracker task will be used to house my Summer of Code work. For information about the goals of the project please see http://www.rockbox.org/twiki/bin/view/Main/PluginLocalization . Please read the comments and the descriptions of each patch.

Latest patch: single_lang_file.diff
Posted: August 13th
This task depends upon

View Dependency Graph

This task blocks these from closing
FS#9348 - JPEG Viewer on iPod
Comment by Tom Ross (midgey34) - Tuesday, 03 June 2008, 08:46 GMT+1
This patch is my latest attempt to allow for localized plugins. It uses the plugin buffer to store the plugin strings. As a demo, Blackjack has been translated into "Spanish" but not fully. The introduction screen is always in English and there are some formatting issues when entering a bet on certain targets. Please see the wiki page for more details on the implementation.

This patch was tested on Gigabeat F, iriver H300, and Sansa e200. For mentors following the project, this is the same as v9.5 .
   plugin_lang_work.diff (56.5 KiB)
Comment by Tom Ross (midgey34) - Wednesday, 09 July 2008, 18:42 GMT+1
This patch contains further improvements on localized plugins. Chopper and Chessbox have been mostly adapted and translated into "Spanish." This patch also uses the user keyword from lang files to restrict access to strings. If a plugin tries to access a string that has a different user, the returned string will be blank. Originally this was an attempt at loadable strings but this version saves no new ram. I mentioned a proposal about loadable strings in my emails to Daniel and Stephane and I'd like to discuss the ideas on IRC.

Additionally in this patch plugins can now talk. Run 'make voice' to create a voice build as normal. Then go into Blackjack and listen to how it talks to you. So far only parts of Blackjack are voiced. It would be nice for someone to attach a voice file (created by Festival) to allow other people to quickly test out the patch.
   plugin_talk.diff (84.6 KiB)
Comment by Tom Ross (midgey34) - Monday, 21 July 2008, 05:38 GMT+1
This patch implements the beginning of loading lang strings from file offsets as I discussed with amiconn. I sent this out to Bagder and sdoyon but I think they're both on break. Some of these changes are for my own purposes to make building take less time or get around mac specific quirks.
   plugin_lang_offsets.diff (91.5 KiB)
Comment by Tom Ross (midgey34) - Wednesday, 13 August 2008, 08:41 GMT+1
Here's my latest work. This version changes to using a single lang file per language. It's still rough around the edges but works fairly well. Like previous version, plugins can be translated into multiple languages and strings can be voiced. A fairly significant change is the ability to now use the ID2P() macro in conjunction with splashes within plugins.

I've split the code changes from the language changes to make the code more easily reviewable. If you want to compile a build to test out my work, both patches are required.
lang_changes.zip contains lang_changes.diff which are the required changes to the lang files
single_lang_file.diff are all the code changes

Note: I don't think this will compile and work on target. I've broken that with this patch and I need to make a few changes to makefiles to fix it.
   single_lang_file.diff (68.8 KiB)
   lang_changes.zip (707.7 KiB)

Loading...