Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9069 - Rockedit : new text editor for Rockbox

Attached to Project: Rockbox
Opened by Clément Pit--Claudel (CFP) - Tuesday, 03 June 2008, 19:23 GMT+2
Task Type Patches
Category Plugins
Status Unconfirmed
Assigned To No-one
Player Type Gigabeat F/X
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

Hello,
I've recently designed new text editing plugin for Rockbox, which I called (how original...) rockedit. The point is not to compete with current text_editor, but rather to develop a new approach to text editing by, in particular, allowing user to work in insert/replace mode. The major difference is that the keypad has been replaced by a single which the user navigates through using up/down, while left/right are used to change current char. Fire key is used to switch between different chars lists.
I didn't manage, though, to use keypad as set in r17659. The diff file just reverts it, which is not a good solution at all... Furthermore, I haven't tested it on any other target but my gigabeat : I cannot boot Windows currently.

I've included a patch which includes keymap changes, and another which doesn't. I've also added a screenshot.
Please do comment and help me improve this editor !
   rockedit.diff (21.8 KiB) 
 apps/plugins/CATEGORIES                                 |    2 
 apps/plugins/viewers.config                             |    1 
 apps/plugins/typing.c                                   |  456 ++++++++++++++++
 apps/plugins/typing.h                                   |    2 
 apps/plugins/rockedit.c                                 |  273 +++++++++
 apps/plugins/SOURCES                                    |    2 
 firmware/target/arm/s3c2440/gigabeat-fx/button-target.h |   17 
 firmware/target/arm/s3c2440/gigabeat-fx/button-meg-fx.c |   15 
 8 files changed, 759 insertions(+), 9 deletions(-)

   rockedit_no_button_change.diff (20 KiB) 
 apps/plugins/CATEGORIES     |    2 
 apps/plugins/viewers.config |    1 
 apps/plugins/typing.c       |  456 ++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/typing.h       |    2 
 apps/plugins/rockedit.c     |  273 ++++++++++++++++++++++++++
 apps/plugins/SOURCES        |    2 
 6 files changed, 736 insertions(+)

   main_screen.jpg (66 KiB)
   typing.jpg (46.3 KiB)
This task depends upon

Comment by Clément Pit--Claudel (CFP) - Thursday, 12 June 2008, 21:06 GMT+2
Lots of fixes :
*Removed keymap changes -> now diff only modifies files in plugins directory
*Added wordwrap functionality
*Fixed various bugs
   rockedit.diff (20.8 KiB) 
 apps/plugins/CATEGORIES     |    1 
 apps/plugins/viewers.config |    1 
 apps/plugins/typing.c       |  496 ++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/typing.h       |    2 
 apps/plugins/rockedit.c     |  278 ++++++++++++++++++++++++
 apps/plugins/SOURCES        |    2 
 6 files changed, 780 insertions(+)

Comment by Clément Pit--Claudel (CFP) - Sunday, 15 June 2008, 12:50 GMT+2
V3 : Implemented wordwrap, and fixed a few bugs.
   rockedit.diff (22.3 KiB) 
 apps/plugins/CATEGORIES     |    1 
 apps/plugins/viewers.config |    1 
 apps/plugins/typing.c       |  552 ++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/typing.h       |    2 
 apps/plugins/rockedit.c     |  287 ++++++++++++++++++++++
 apps/plugins/SOURCES        |    2 
 6 files changed, 845 insertions(+)

Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 10 August 2008, 13:01 GMT+2
I would like to suggest a new layout for the text_editor. You can navigate faster with the wheel or the other keys, if the letters, numbers and additional characters are separated. Please look at the file...
   test_editor.doc (102.5 KiB)
Comment by Clément Pit--Claudel (CFP) - Sunday, 10 August 2008, 16:36 GMT+2
I'm not sure that I fully understand the contents of your file. Do you mean I should do something like :
2 lines A-Z/a-z
1 line 0-9
1 line for special chars ?
If so, sure ! I will implement this as soon as I'm home, ie. around the 25th. Where do you think .?! should go ?
CFP
Comment by Johannes Schwarz (Ubuntuxer) - Sunday, 10 August 2008, 18:56 GMT+2
Do you the texteditor from the Iphone?
Normaly just the letters are displayed, but you can switch by select the button 123, now just numbers are displayed. Do you understand me?
sorry I can't explain it you better, I'm not so familiary with english, because I'm from Germany.
Comment by Clément Pit--Claudel (CFP) - Monday, 11 August 2008, 06:48 GMT+2
In fact, there was no problem with your english, but rather with the way your file was to be understood. Got it this time though : )
Cfp.
Comment by Johannes Schwarz (Ubuntuxer) - Monday, 11 August 2008, 14:49 GMT+2
What do you think about it? Do you think it's useful to separated the numbers and additional characters?
Comment by David B (DefineByte) - Wednesday, 13 August 2008, 13:28 GMT+2
If we're talking /a lot/ of special characters I think it would be better if they were separated.
Comment by Clément Pit--Claudel (CFP) - Tuesday, 26 August 2008, 22:45 GMT+2
Concentrate on the new keypad by dropping the "rockedit" part of the plugin. Separate numbers from special chars, and correct code to match new splashf syntax.
   keypad_demo.diff (14.7 KiB) 
 apps/plugins/CATEGORIES    |    1 
 apps/plugins/keypad_demo.c |  552 +++++++++++++++++++++++++++++++++++++++++++++
 apps/plugins/keypad_demo.h |    2 
 apps/plugins/SOURCES       |    1 
 4 files changed, 556 insertions(+)

Loading...