Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9114 - Pause Between Tracks

Attached to Project: Rockbox
Opened by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 24 June 2008, 12:22 GMT+1
Task Type Patches
Category Applications
Status New
Assigned To No-one
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

This patch adds a new playback option, Pause Between Tracks. It pauses the playback automatically after each track, and the user must press Play to play the next.

This is useful for e.g dance classes, sound effects etc.

There is a noticeable lag in the simulator, where it starts the playback of the next song before pausing, but who cares? It seems to work fine on the target anyway.

Try it!
This task depends upon

Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 24 June 2008, 12:22 GMT+1
...and here's the patch.
   pause_between_tracks.patch (6 KiB)
Comment by Marianne Arnold (pixelma) - Tuesday, 24 June 2008, 13:03 GMT+1
Maybe I'm misunderstanding something (but don't think because compiling for my OndioFM fails "In file included from playback.c:42: codecs.h:222: warning:..." etc.) but it looks like you enabled compiling playback.c on hwcodec (in apps/SOURCES).

Edit: It only gives the warning, failing had another reason).
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 24 June 2008, 13:21 GMT+1
Yes, it is supposed to compile playback.c, because I didn't want to duplicate the event handling code.

I'll fix the warnings, though.
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 24 June 2008, 13:25 GMT+1
Here is an updated version, without warnings.
   pause_between_tracks-2.patch (6.5 KiB)
Comment by Steve Bavin (pondlife) - Tuesday, 24 June 2008, 18:04 GMT+1
Maybe the event handling code could be moved to another module?

I'd personally/selfishly prefer to keep playback.c and HWCODEC apart, because I have no HWCODEC target to test with.
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 24 June 2008, 22:21 GMT+1
Maybe. Care to modify the patch accordingly?
Comment by Steve Bavin (pondlife) - Wednesday, 25 June 2008, 10:52 GMT+1
Of course, but probably not for a week or 2 ;-)

Real Life is such an intrusive thing.
Comment by Linus Nielsen Feltzing (linusnielsen) - Tuesday, 05 August 2008, 11:10 GMT+1
The question is where to move it, since the code really belongs in the playback module. I could of course duplicate the code...

Loading...