Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9139 - Add support for version 1.1 .scrobbler.log (last.fm) files

Attached to Project: Rockbox
Opened by Robert Keevil (obo) - Tuesday, 01 July 2008, 21:42 GMT+2
Last edited by Robert Keevil (obo) - Tuesday, 07 October 2008, 20:40 GMT+2
Task Type Patches
Category ID3 / meta data
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes Rockbox write version 1.1 .scrobbler.log (last.fm) files - the only change really being the the addition of MusicBrainz Track IDs - this requires one extra tag to be read. This patch adds this support (for MP3, Ogg, M4A and WMA).
   mbid-080701.patch (6.9 KiB) 
 apps/screens.c                  |   12 ++++++++----
 apps/metadata/mp4.c             |    5 +++++
 apps/metadata/asf.c             |    3 +++
 apps/metadata/metadata_common.c |    5 +++++
 apps/lang/english.lang          |   14 ++++++++++++++
 apps/scrobbler.c                |   12 +++++++-----
 firmware/export/id3.h           |    3 +++
 firmware/id3.c                  |   31 +++++++++++++++++++++++++++++++
 8 files changed, 76 insertions(+), 9 deletions(-)

This task depends upon

Closed by  Robert Keevil (obo)
Tuesday, 07 October 2008, 20:40 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Commited as r18732
Comment by Robert Keevil (obo) - Tuesday, 08 July 2008, 20:21 GMT+2
Updated - only write data to .scrobbler.log if there is data to write.

Patch increases binsize by 682 and RAM usage by 688 bytes on a ipod 5g.
   mbid-080708.patch (6.9 KiB) 
 apps/screens.c                  |   12 ++++++++----
 apps/metadata/mp4.c             |    5 +++++
 apps/metadata/asf.c             |    3 +++
 apps/metadata/metadata_common.c |    5 +++++
 apps/lang/english.lang          |   14 ++++++++++++++
 apps/scrobbler.c                |   12 +++++++-----
 firmware/export/id3.h           |    3 +++
 firmware/id3.c                  |   31 +++++++++++++++++++++++++++++++
 8 files changed, 76 insertions(+), 9 deletions(-)

Loading...