Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9156 - rockboxdev.sh does not abort when downloading fails

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Sunday, 06 July 2008, 14:24 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Sunday, 10 August 2008, 16:36 GMT+2
Task Type Bugs
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The rockboxdev.sh script download files using the getfile function.
This function does not verify that the download tool returned error code 0.

For example, when there is no internet connection, the script should fail when trying to download the first file.

The patch adds this test to the script.
   fix_abort_when_download_fails.diff (0.6 KiB) 
 tools/rockboxdev.sh |    9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Sunday, 10 August 2008, 16:36 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Thanks!
Comment by Tomer Shalev (tomers) - Thursday, 07 August 2008, 22:29 GMT+2
Previous patch is broken due to code change. I'm uploading an updated patch (no changes to code).
   fix_abort_when_download_fails.diff (0.5 KiB) 
 tools/rockboxdev.sh |    6 ++++++
 1 file changed, 6 insertions(+)

Loading...