Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9157 - Tidy up some MAS35XX constants

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Sunday, 06 July 2008, 14:35 GMT+2
Last edited by Tomer Shalev (tomers) - Thursday, 01 October 2009, 07:25 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To Tomer Shalev (tomers)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I reviewed the MAS35XX and tidy up the code some.
Mostly used constant instead of values. Some of them where added by referring to the appropriate data-sheet as reference.
   tidy_up_some_mas35xx_constants.diff (5.4 KiB) 
 firmware/export/mas.h            |   25 +++++++++++++++++++------
 firmware/drivers/audio/mas35xx.c |   28 ++++++++++++++--------------
 2 files changed, 33 insertions(+), 20 deletions(-)

This task depends upon

Closed by  Tomer Shalev (tomers)
Thursday, 01 October 2009, 07:25 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22865.
Comment by Tomer Shalev (tomers) - Sunday, 06 July 2008, 14:37 GMT+2
MAS35XX various datasheets.

TODO: Add them to the appropriate wiki page.
(application/pdf)    mas3507d.pdf (813.5 KiB)
(application/pdf)    mas3539f.pdf (1.16 MiB)
(application/pdf)    mas3587f.pdf (734.2 KiB)

Loading...