Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9170 - Patches to fix profile builds , profile behaviour , profile_reader tool

Attached to Project: Rockbox
Opened by Dave Hooper (stripwax) - Wednesday, 09 July 2008, 01:34 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Tuesday, 29 July 2008, 00:47 GMT+2
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Fixes #define clash between profiling code and sudoku plugin

Fixes profile instrumentation function names to match what gcc expects (please can someone confirm on a non-cygwin build environment that this does indeed also work for them)

Fixes profiling code to pass required CPU/COP arg to timer_register() on devices with cop

Fixes profile_reader to execute the correct objdump executable (=> now passed on command line as new required argument - e.g. "profile_reader profile.out arm-elf-objdump ...")

Adds error message when no output sort order is specified (no order => no output! confusing to just get no output and no explanation why not)

Fixes sort order in profile_reader output (wasn't sorting numeric fields numerically before, or at least not correctly!)

Fixes linked list depth always being zero in output (column: "DEPTH" value always 0000 - recursive print code was recursing with depth++ rather than ++depth!!)

Then also some probably more contentious changes:
When profiling build is enabled, don't build alac.codec, doom, and mpegplayer. These cannot link on ipod video builds due to iram usage of profiling code
   profile_fixes.patch (9.8 KiB) 
 tools/profile_reader/profile_reader.pl |   39 ++++++++++++++++++++++-----------
 apps/codecs.c                          |    4 +--
 apps/plugins/sudoku/generator.c        |    4 +--
 apps/plugins/SUBDIRS                   |    4 +++
 apps/plugin.c                          |    4 +--
 apps/codecs/SOURCES                    |    2 +
 firmware/export/profile.h              |    4 +--
 firmware/profile.c                     |   23 +++++++++++--------
 8 files changed, 54 insertions(+), 30 deletions(-)

This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Tuesday, 29 July 2008, 00:47 GMT+2
Reason for closing:  Accepted
Comment by Dave Hooper (stripwax) - Sunday, 20 July 2008, 16:29 GMT+2
Looks like the generator.c diff is no longer required, presumably the conflicting #define got moved since I started the patch.
Updated patch attached
   profile_fixes.patch (9.3 KiB) 
 tools/profile_reader/profile_reader.pl |   39 ++++++++++++++++++++++-----------
 apps/codecs.c                          |    4 +--
 apps/plugins/SUBDIRS                   |    4 +++
 apps/plugin.c                          |    4 +--
 apps/codecs/SOURCES                    |    2 +
 firmware/export/profile.h              |    4 +--
 firmware/profile.c                     |   23 +++++++++++--------
 7 files changed, 52 insertions(+), 28 deletions(-)

Loading...