Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9197 - Return correct failure code if the WPS has too many viewports

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Tuesday, 15 July 2008, 21:15 GMT+1
Task Type Patches
Category Applications
Status Assigned
Assigned To Nicolas Pennequin (nicolas_p)
Player type All players
Severity Low
Priority Normal
Reported Version current build
Due in Version Undecided
Due Date Undecided
Percent Complete 0%
Private No

Details

The title says it all, I have nothing to add
   wps_parser.patch (0.5 KiB)
This task depends upon

Comment by Nicolas Pennequin (nicolas_p) - Wednesday, 16 July 2008, 01:11 GMT+1
Have you tested this patch? I don't think it will work correctly, because the value of PARSE_FAIL_LIMITS_EXCEEDED is positive, whereas parsing functions like parse_viewport are supposed to return either the number of characters they read or a strictly negative error value. Maybe there is no apparent problem (thanks to the other check for the viewport limit), but this looks wrong to me.
Comment by Alexander Levin (fml2) - Wednesday, 16 July 2008, 07:23 GMT+1
To be honest, I have not tested the patch. I just have seen that a wrong literal is used in this case and have assumed that the general frame is correctly set up. If it's not, then a fix is needed at another place (but this fix is still correct IMHO).
Comment by Alexander Levin (fml2) - Wednesday, 16 July 2008, 20:39 GMT+1
Here is another try. Now also tested, although not very extensively. Also added some comments.
   wps_parser2.patch (13.1 KiB)

Loading...