- Status Closed
- Percent Complete
- Task Type Patches
- Category Applications
-
Assigned To
nicolas_p - Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9197 - Return correct failure code if the WPS has too many viewports
The title says it all, I have nothing to add
Closed by fml2
2010-10-11 14:56
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2010-10-11 14:56
Reason for closing: Rejected
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
A very old patch; obsoltete by now
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Have you tested this patch? I don’t think it will work correctly, because the value of PARSE_FAIL_LIMITS_EXCEEDED is positive, whereas parsing functions like parse_viewport are supposed to return either the number of characters they read or a strictly negative error value. Maybe there is no apparent problem (thanks to the other check for the viewport limit), but this looks wrong to me.
To be honest, I have not tested the patch. I just have seen that a wrong literal is used in this case and have assumed that the general frame is correctly set up. If it’s not, then a fix is needed at another place (but this fix is still correct IMHO).
Here is another try. Now also tested, although not very extensively. Also added some comments.