Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9233 - Link Rockbox Utility dynamically against the system's libspeex

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Saturday, 02 August 2008, 17:45 GMT+2
Last edited by Dominik Riebeling (bluebrother) - Thursday, 08 October 2009, 23:27 GMT+2
Task Type Patches
Category Rbutil
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch makes Rockbox Utility link against the system libspeex, rather than using the copy in apps/

It's currently hard-coded and expects libspeex to be in /usr/lib - ideally it'd be smarter about this, and fall back to using the one in apps/ if there's no libspeex to be found.
   rbutil-systemlibspeex-v1.diff (1.5 KiB) 
 tools/rbspeex/Makefile       |    5 +++--
 rbutil/rbutilqt/rbutilqt.pro |    2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

This task depends upon

Closed by  Dominik Riebeling (bluebrother)
Thursday, 08 October 2009, 23:27 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  a similar solution utilizing pkg-config has been committed.
Comment by Jonas Häggqvist (rasher) - Saturday, 02 August 2008, 18:16 GMT+2
Tested with an X5 sim - the generated talk clips and voice files do in fact work.
Comment by Jonas Häggqvist (rasher) - Saturday, 02 August 2008, 20:42 GMT+2
This patch adds autodetection to tools/rbspeex/Makefile, preferring to use the system's libspeex if available.

Some similar magic is still needed for rbutil/rbutilqt/rbutilqt.pro
   rbutil-systemlibspeex-FS9233-v2.diff (2.2 KiB) 
 tools/rbspeex/Makefile       |   20 ++++++++++++++------
 rbutil/rbutilqt/rbutilqt.pro |    2 +-
 2 files changed, 15 insertions(+), 7 deletions(-)

Comment by Jonas Häggqvist (rasher) - Saturday, 02 August 2008, 22:36 GMT+2
This is an attempt at adding such magic to rbutil/rbutilqt/rbutilqt.pro, but it doesn't work. It also makes tools/rbspeex/Makefile sensitive to the STATIC define, which causes it to always link against the Rockbox libspeex.
   rbutil-systemlibspeex-FS9233-v3.diff (2.9 KiB) 
 tools/rbspeex/Makefile       |   25 +++++++++++++++++++------
 rbutil/rbutilqt/rbutilqt.pro |   30 ++++++++++++++++++++++++++----
 2 files changed, 45 insertions(+), 10 deletions(-)

Loading...