Rockbox

Tasklist

FS#9280 - fix "make tar" for BSD tar compatibility

Attached to Project: Rockbox
Opened by Geert Hendrickx (ghen) - Thursday, 14 August 2008, 13:27 GMT
Last edited by Jens Arnold (amiconn) - Tuesday, 26 August 2008, 23:23 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The "make tar" target uses tar -u to update an existing tarfile. This doesn't work however with BSD tar if the tarfile doesn't exist yet, and the Makefile explicitly removes the tarfile initially (so why use -u anyway?). Changing -u (update) into -c (create) makes this compatible with both GNU and BSD tar (tested on NetBSD with both versions of tar).
This task depends upon

Closed by  Jens Arnold (amiconn)
Tuesday, 26 August 2008, 23:23 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fix committed to SVN, including the necessary buildzip.pl changes.
Comment by Geert Hendrickx (ghen) - Tuesday, 26 August 2008, 22:10 GMT
"tar -c" is not the proper solution since $ziptool may be called twice (when including fonts).

As agreed on IRC, it would be better to modify buildzip.pl to call $ziptool only once.

Loading...