This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9338 - Fix rockboxdev.sh
Attached to Project:
Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 30 August 2008, 12:21 GMT+2
Last edited by Daniel Stenberg (bagder) - Monday, 01 December 2008, 14:26 GMT+2
Opened by Tomer Shalev (tomers) - Saturday, 30 August 2008, 12:21 GMT+2
Last edited by Daniel Stenberg (bagder) - Monday, 01 December 2008, 14:26 GMT+2
|
DetailsThis patch fixes the following issue:
1. When gmake is missing, `which qmake` produces error message. Therefore changed to `which gmake 2> /dev/null` 2. mkdir $builddir is called only if that directory is not previously exists. This happens when the user selects 'all' architectures, and builddone() is called more than once. 3. Instead of download all needed files, then extract all of them, I changed behavior to download & extract each file. This makes code prettier. 4. Added -N parameter to 'patch' so that it patches only if files are not already patched, and ignore otherwise, without asking the user whether it is a reversed patch. 
fix_rockboxdev.sh.diff
(1.7 KiB)
tools/rockboxdev.sh | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) |
This task depends upon
Closed by Daniel Stenberg (bagder)
Monday, 01 December 2008, 14:26 GMT+2
Reason for closing: Accepted
Additional comments about closing: Thanks, I did the gmake stderr fix and the others I didn't particularly like so I didn't apply them!
Monday, 01 December 2008, 14:26 GMT+2
Reason for closing: Accepted
Additional comments about closing: Thanks, I did the gmake stderr fix and the others I didn't particularly like so I didn't apply them!
Patches should address one issue each. Fixing bugs is one issue (well not really, since each is a separate bug, but it can be justified as such), "make it look nicer" is a separate thing entirely.