Rockbox

Tasklist

FS#9338 - Fix rockboxdev.sh

Attached to Project: Rockbox
Opened by Tomer Shalev (tomers) - Saturday, 30 August 2008, 10:21 GMT
Last edited by Daniel Stenberg (bagder) - Monday, 01 December 2008, 13:26 GMT
Task Type Bugs
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch fixes the following issue:

1. When gmake is missing, `which qmake` produces error message.
Therefore changed to `which gmake 2> /dev/null`

2. mkdir $builddir is called only if that directory is not previously exists. This happens when the user selects 'all' architectures, and builddone() is called more than once.

3. Instead of download all needed files, then extract all of them, I changed behavior to download & extract each file. This makes code prettier.

4. Added -N parameter to 'patch' so that it patches only if files are not already patched, and ignore otherwise, without asking the user whether it is a reversed patch.
This task depends upon

Closed by  Daniel Stenberg (bagder)
Monday, 01 December 2008, 13:26 GMT
Reason for closing:  Accepted
Additional comments about closing:  Thanks, I did the gmake stderr fix and the others I didn't particularly like so I didn't apply them!
Comment by Paul Louden (Llorean) - Sunday, 31 August 2008, 09:32 GMT
Please don't combine actual fixes to problems with personal preferences for code prettiness improvements.

Patches should address one issue each. Fixing bugs is one issue (well not really, since each is a separate bug, but it can be justified as such), "make it look nicer" is a separate thing entirely.

Loading...