Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9353 - New WPS Tags (Feature idea 18338)

Attached to Project: Rockbox
Opened by Clément Pit--Claudel (CFP) - Tuesday, 02 September 2008, 09:39 GMT+2
Last edited by Maurus Cuelenaere (mcuelenaere) - Tuesday, 03 March 2009, 14:35 GMT+2
Task Type Patches
Category Themes
Status Closed
Assigned To No-one
Player Type SW-codec
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I implemented what had been discussed in formu thread http://forums.rockbox.org/index.php?topic=18338.0 , ie. 3 new WPS tags : crossfeed state (%fe), balance (%ba), and channel configuration(%ch).
I don't really have any idea on how to implement a way to acccess options by name in wps, so I used a more straight-forward method.
CFP.
   newtags.diff (2.8 KiB) 
 apps/gui/gwps-common.c       |   18 ++++++++++++++++++
 apps/gui/wps_parser.c        |    3 +++
 apps/gui/gwps.h              |    3 +++
 manual/appendix/wps_tags.tex |    3 +++
 4 files changed, 27 insertions(+)

This task depends upon

Closed by  Maurus Cuelenaere (mcuelenaere)
Tuesday, 03 March 2009, 14:35 GMT+2
Reason for closing:  Duplicate
Additional comments about closing:  The author stated the task could get closed.
Comment by Clément Pit--Claudel (CFP) - Tuesday, 02 September 2008, 09:55 GMT+2
Balance and channels are not limited to swcodec targets
   newtags.diff (3 KiB) 
 apps/gui/gwps-common.c       |   18 ++++++++++++++++++
 apps/gui/wps_parser.c        |    4 ++++
 apps/gui/gwps.h              |    3 +++
 manual/appendix/wps_tags.tex |    3 +++
 4 files changed, 28 insertions(+)

Comment by Antoine Cellerier (dionoea) - Friday, 05 September 2008, 16:02 GMT+2
Patches posted on task 9368 add a generic %St|<option name>| WPS tag.
Comment by Clément Pit--Claudel (CFP) - Friday, 05 September 2008, 19:50 GMT+2
Then this task might be closed, unless it is useful to have special wps tags for these options.

Loading...