Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9400 - tools/configure more improvements

Attached to Project: Rockbox
Opened by Rosso Maltese (asettico) - Sunday, 14 September 2008, 17:00 GMT+2
Last edited by Thomas Martitz (kugel.) - Sunday, 09 August 2009, 21:03 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch extends the improvements supplied by #8842 to all the values read from stdin.
The command line options added are:

--atype=ATYPE
--language=LANG
--tts=ENGINE
--ttsopts=OPTS
--encopts=OPTS

ATYPE can be a string containing one or more letters, as showed in advanced build menu.
   configure-args.patch (8.3 KiB) 
 tools/configure |  158 +++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 100 insertions(+), 58 deletions(-)

This task depends upon

Closed by  Thomas Martitz (kugel.)
Sunday, 09 August 2009, 21:03 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22228. Thanks a lot!
Comment by Rosso Maltese (asettico) - Monday, 23 February 2009, 18:05 GMT+2
Sync'd against today's daily build (r20089).
   9400configure-args.0.patch (8.1 KiB) 
 tools/configure |  151 +++++++++++++++++++++++++++++++++++---------------------
 1 file changed, 96 insertions(+), 55 deletions(-)

Comment by Thomas Martitz (kugel.) - Friday, 12 June 2009, 11:58 GMT+2
Would it be possible to remove --atype, and fuse it with --type? You can't have both at the same time, so --type could be replaced if "a" is given or something.
Comment by Rosso Maltese (asettico) - Friday, 12 June 2009, 12:08 GMT+2
I' sync-ed it with current build to fix some line number offsets and fuzz factor. I just have to upload the new file.
I can think to reorganize the added arguments. I'm not sure, but maybe I added the option atype since due to an overload between normal and advanced options, so it's possible to use the same letters as indicated by the output in the intercative execution. But I need to check them.
Stay tuned! :-)
Comment by Thomas Martitz (kugel.) - Friday, 12 June 2009, 12:11 GMT+2
I'm thinking if --type starts with "a" then it can't be a normal build anymore, so overloading sounds possible to me.
Comment by Rosso Maltese (asettico) - Friday, 12 June 2009, 17:52 GMT+2
Here it is the updated patch, sync'd against build r21259.
It supports following command line arguments (some of them belong to  FS#8842 ):
--target=TARGET
--ram=RAM
--type=TYPE
--language=LANG
--tts=ENGINE
--voice=VOICE
--ttsopts=OPTS
--encopts=OPTS
--rbdir=DIR
--ccache
--no-ccache
--help

Now --type accepts a string to select multiple options.
So, if I want to build voice, I will do:
../tools/configure --type=av ...

For the bootloader, I will do:
../tools/configure --type=b ...

For the backlight option (when allowed), I will do:
../tools/configure --type=ab ...

(According with my naming rule for the patch files, last number before the extension indicates the value to be used in patch -p. HTH)
   build-9400configure-args_v3.0.patch (12.2 KiB) 
 tools/configure |  228 ++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 141 insertions(+), 87 deletions(-)

Comment by Thomas Martitz (kugel.) - Friday, 12 June 2009, 19:37 GMT+2
Great, gonna check this out
Comment by Rosso Maltese (asettico) - Saturday, 20 June 2009, 15:13 GMT+2
Sync'ed against current build (r21388).
   build-9400configure-args_v4.0.patch (12.6 KiB) 
 tools/configure |  236 ++++++++++++++++++++++++++++++++++----------------------
 1 file changed, 144 insertions(+), 92 deletions(-)

Comment by Thomas Martitz (kugel.) - Saturday, 20 June 2009, 16:22 GMT+2
Seems to work well! I'm all for committing (I think I'll do it soonish).
Comment by Thomas Martitz (kugel.) - Saturday, 20 June 2009, 21:25 GMT+2
Alright, I have had a look.

Nothing against the patch itself, but we're getting short on args. The current implementation is badly limited to 10 arguments. This will make adapting make reconf quite hard (it passes all arguments at once). Do you have some plans regarding that?

Also, I was having problems with voice builds. Well, I don't have any voice engine installed, but maybe you can take another look at it?
Comment by Rosso Maltese (asettico) - Saturday, 20 June 2009, 22:25 GMT+2
Actually, I already saw that fancy use of the command line arguments. Maybe a simple "$@" can fix the problem, but I need to investigate.
Probably a clearer way to manage the arguments should be implemented. I will try to rewrite it without change the script logic.
Thanks for the warning.
Comment by Thomas Martitz (kugel.) - Saturday, 20 June 2009, 22:52 GMT+2
That rewrite should probably done before this patch, what do you say?

It would be awesome if you volunteer for that. It's obvious I fail at this thing :)
Comment by Rosso Maltese (asettico) - Saturday, 20 June 2009, 23:04 GMT+2
Absolutely yes.
The major problem is that I'm thinking to completely rewrite the script, but I don't know the use of the different compiler options, so a slight mistake on reproducing the same use of them could lead to a big headaches. ;-)
Anyway I will try.
Comment by Thomas Martitz (kugel.) - Saturday, 20 June 2009, 23:15 GMT+2
Completely rewriting seems a bit exaggerated. Is there any need to?
Comment by Rosso Maltese (asettico) - Saturday, 20 June 2009, 23:33 GMT+2
Ok, "completely" is really exaggerated. I will concentrate just on the arguments.
Comment by Rosso Maltese (asettico) - Tuesday, 23 June 2009, 00:58 GMT+2
Sync'ed against current build (r21475).
No changes introduced yet about command line arguments as discussed earlier.
   build-9400configure-args_v5.0.patch (13 KiB) 
 tools/configure |  244 +++++++++++++++++++++++++++++++++-----------------------
 1 file changed, 147 insertions(+), 97 deletions(-)

Comment by Rosso Maltese (asettico) - Tuesday, 23 June 2009, 12:37 GMT+2
This patch, applied after "build-9400configure-args_v5.0.patch" of the previous comment, normalize the script indentation ( vim: :set shiftwidth=4 tabstop=4 expandtab).
   build-9400configure-args_v5-indent.0.patch (142.2 KiB) 
 tools/configure | 4385 +++++++++++++++++++++++++++-----------------------------
 1 file changed, 2189 insertions(+), 2196 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 12 July 2009, 02:56 GMT+2
Any progress?

PS: We don't want the indentation changes I think.
Comment by Rosso Maltese (asettico) - Tuesday, 14 July 2009, 13:18 GMT+2
I'm sorry, Thomas, I started working hard again, so my spare time is reduced!
I hope to complete the arguments management soon.
OK, for the indentation, I did it just because I found it a little bit fuzzy! ;-)
Comment by Rosso Maltese (asettico) - Sunday, 02 August 2009, 20:56 GMT+2
Here it is the "final" patch.
I'm not sure about the use of the options --ccache and --no-ccache, but I think to be maintained the original behaviour.
Note: some options work together (i.e. --type=av --encopts='-c 10 -q 10'). If you want to leave an option value empty, set it to a blank, like --type=av --ttsopts=' '
   build-9400configure-args_v6.0.patch (15.3 KiB) 
 tools/configure |  339 ++++++++++++++++++++++++++++++++------------------------
 1 file changed, 194 insertions(+), 145 deletions(-)

Comment by Thomas Martitz (kugel.) - Sunday, 02 August 2009, 21:00 GMT+2
I'll have a look!

Loading...