Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Patches
  • Category Playlists
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by jdgordon - 2008-09-17
Last edited by jdgordon - 2008-09-20

FS#9408 - remove global_status.random_seed which I beleive isnt actually needed, NEEDS TESTING

this patch removes some code dealing with reloading the random seed from the global_status which I’m fairly certain was dead code…

in my quick testing with this patch with shuffling both with the menu option and in the quickscreen I can resume the playlist as it was correctly.

this patch also reclaims 4 bytes from the hwcodec nvram targets (and will invalidate your current playlist resume info)

   playlist.diff (4 KiB)
Closed by  jdgordon
2008-09-20 15:26
Reason for closing:  Accepted
learman commented on 2008-09-18 18:35

Hm, yes, it does look like actually comes from the playlist_control file, using the PLAYLIST_COMMAND_SHUFFLE command… If so, it should be safe to remove.

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing