Rockbox

  • Status Closed
  • Percent Complete
    100%
  • Task Type Bugs
  • Category Infrastructure → Build environment
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by lassauge - 2008-09-26
Last edited by nls - 2008-10-08

FS#9421 - "Official" release not OK

Wrong or missing links in website for ‘official 3.0’:
- on main page the link ‘Rockbox 3.0 is released!’ goes to http://www.rockbox.org/download/ where it is said: ‘There is no “current” release’. However the 3.0 is available at ‘http://download.rockbox.org/release/3.0/

- rockbox-3.0.7z tarball (7zipball ?) has also some problems:
* Zip file should contain directory rockbox-3.0
* docs/VERSION file should exist and contain the ‘official’ release number

- lang files are not OK:
* LANG_ALBUMART is only available in english and italiano: if you change ‘export LANGUAGE=francais’ it will not compile
* the francais.lang file is wrong (patch included) and doesn’t work correctly for some strings if loaded dynamically

Closed by  nls
2008-10-08 19:31
Reason for closing:  Fixed
Additional comments about closing:   Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407

The source archive was fixed and the lang fixes in the patch was committed.
Thanks!

The first problem, regarding the release page not displaying the new information, can be solved by hitting refresh on your browser - it's loading a cached version.

nls commented on 2008-09-28 05:03

The 7z archive appears to have been created from the trunk not the release branch. LANG_ALBUMART is not present in the release.
Support for setting LANGUAGE when building has been removed.
What is it that's wrong in the francais.lang? what happens when it's loaded dynamically and how does your patch fix it?

nls commented on 2008-09-29 18:44

The source archive has been fixed.

I attach a modified patch to francais.lang only.

As discussed on IRC, "Œuvre" is a better translation for "Work" in the context of the ID3 grouping tag.
I also removed the modification of the translation of "Previous":
- "PrécédEnt" as an adjective is more intuitive than the verbal form "PrécédAnt"

here is a non empty patch

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing