Rockbox

Tasklist

FS#9475 - Make timeout parsing more flexible in wps_parser

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Saturday, 11 October 2008, 21:25 GMT
Last edited by Alexander Levin (fml2) - Monday, 11 October 2010, 14:55 GMT
Task Type Patches
Category Applications
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The patch splits the parse_timeout function into a worker one and the functions used for a specific tag thus allowing to define context sensitive logic more locally. Also, the worker function doesn't need to know where it is called from.
This task depends upon

Closed by  Alexander Levin (fml2)
Monday, 11 October 2010, 14:55 GMT
Reason for closing:  Rejected
Additional comments about closing:  The patch is very probably obsolete by now; code has moved on.
Comment by Jonathan Gordon (jdgordon) - Sunday, 12 October 2008, 00:33 GMT
I see what your doing, but im not sureits worth doing untill at least one or a few more tags want to use it
Comment by Alexander Levin (fml2) - Sunday, 12 October 2008, 09:40 GMT
I think that the clean code is always worth it. This way you won't have to remember something that you know now but will forget in a couple of days.

Loading...