Rockbox

Tasklist

FS#9567 - Add support for configurable root directory for Rockbox firmware

Attached to Project: Rockbox
Opened by Alex Bennee (ajb) - Friday, 21 November 2008, 08:57 GMT
Last edited by Björn Stenberg (zagor) - Monday, 24 November 2008, 22:16 GMT
Task Type Patches
Category Build environment
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

The Rockbox file browser has the ability to load new firmware by selecting an alternative rockbox.ipod. However this is rather pointless as the support files in "/.rockbox" will be for the old build.

This series of patches allow you to configure rockbox with an alternate directory:

../tools/configure --target=22 --ram=64 --type=N --rbdir=rockboxdev.alt

Which after building will give you a complete install zip file which extracts into "rockboxdev.alt". Although this build will never be the primary build (the bootloader is hardwired for .rockbox) it does mean you can run a development build without having to break your existing working setup.
This task depends upon

Closed by  Björn Stenberg (zagor)
Monday, 24 November 2008, 22:16 GMT
Reason for closing:  Accepted
Comment by Björn Stenberg (zagor) - Friday, 21 November 2008, 10:21 GMT
Looks fine to me. But can you please upload a single patch done with "svn diff" in the rockbox root, instead of the five different files we have here?
Comment by Alex Bennee (ajb) - Friday, 21 November 2008, 10:56 GMT
Here is the patch in one big file from SVN diff.

I uploaded multiple patches more as an aid to reviewers so I could "show the working" and the comments for each change.

If people prefer reviewing monolithic patches I can just stick with a whole diff for each tracker entry or submit both a series and an "all" patch.
I don't mind applying the patch to a local SVN to generate the diff but git-diff patches should easily apply with "patch -p1 < git-diff.patch".
As you can probably tell I do all my work in a git-svn repo so I can do things in nice bi-sectable discreet steps.
Comment by Björn Stenberg (zagor) - Friday, 21 November 2008, 11:20 GMT
Generally we prefer single "monolithic" patches.

And yes, a git patch should probably work just as well.
Comment by Robert Keevil (obo) - Friday, 21 November 2008, 13:44 GMT
Would it be worth at the same time fixing up the few locations in the source outside of the bootloader where ".rockbox" is still hardcoded?
e.g.:
firmware/include/dircache.h:31
firmware/common/unicode.c:21
firmware/export/font.h:53
Comment by Alex Bennee (ajb) - Friday, 21 November 2008, 16:00 GMT
I'll have a look. I wasn't sure which bits where the bootloader and which the actual firmware.
Comment by Alex Bennee (ajb) - Friday, 21 November 2008, 16:40 GMT
I think I have them all ignoring all the BOOTDIR stuff (for bootcode?) and changes to the manuals (not relevant for user builds?)
Comment by Alex Bennee (ajb) - Friday, 21 November 2008, 16:41 GMT
with the file this time.

Loading...