Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9569 - fix for e200v2 lcd_update_rect

Attached to Project: Rockbox
Opened by Michael Chicoine (mc2739) - Saturday, 22 November 2008, 02:22 GMT+2
Last edited by Dave Chapman (linuxstb) - Tuesday, 16 December 2008, 08:52 GMT+2
Task Type Patches
Category LCD
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch corrects an issue with lcd_update_rect in lcd-e200v2.c

Also, an unnecessary setting for the button light is removed since this function is in backlight-e200v2-fuze.c
   e200v2-lcd-fix.diff (0.6 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

This task depends upon

Closed by  Dave Chapman (linuxstb)
Tuesday, 16 December 2008, 08:52 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed as r19453
Comment by Thomas Martitz (kugel.) - Saturday, 22 November 2008, 17:34 GMT+2
Do the same for fuze as well.

The OF seems to set that GPIO at LCD init though. My guess is now, that due to the inability to configure the button light in the OF, that the OF just turns on the button light always with the lcd and/or backlight.
   e200v2-fuze-lcd-fix.diff (0.8 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |    2 --
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c     |    2 --
 2 files changed, 4 deletions(-)

Comment by Thomas Martitz (kugel.) - Saturday, 22 November 2008, 17:39 GMT+2
Oops, forgot the lcd_update_rect part.

linuxstb should have a look at that before committing, as he wrote the fuze lcd driver which seems to have some similarities with the e200v2 one.
   e200v2-fuze-lcd-fix.diff (1.2 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |    4 +---
 firmware/target/arm/as3525/sansa-fuze/lcd-fuze.c     |    4 +---
 2 files changed, 2 insertions(+), 6 deletions(-)

Comment by Dave Chapman (linuxstb) - Saturday, 22 November 2008, 18:48 GMT+2
Michael,

What "issue" is the use of lcd_framebuffer[x][y] fixing? It doesn't make sense to access the lcd framebuffer that way - it's defined to be [y][x].

Comment by Dave Chapman (linuxstb) - Saturday, 22 November 2008, 19:04 GMT+2
I've just committed the GPIOD part of this patch (for both Fuze and e200v2) to SVN.
Comment by Michael Chicoine (mc2739) - Saturday, 22 November 2008, 19:20 GMT+2
Dave, without this change, on display of the main menu, the display is shifted right when the status bar is on instead of being shifting down. This was the only change that I found that would display the menu properly.
Comment by Michael Chicoine (mc2739) - Saturday, 29 November 2008, 18:32 GMT+2
Do not modify the CCU_IO register since we don't use GPIOD - same change as made in r19257 for Sansa Fuze
   e200v2-lcd-fix-2.diff (0.6 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |    5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

Comment by Jonathan Gordon (jdgordon) - Sunday, 30 November 2008, 01:36 GMT+2
the above patch has been commited.
Comment by Michael Chicoine (mc2739) - Monday, 01 December 2008, 20:54 GMT+2
This patch corrects lcd_update_rect properly. Tested with credits.rock which uses the lcd_update_rect function.
   e200-lcd-fix-3.diff (1.5 KiB) 
 firmware/target/arm/as3525/sansa-e200v2/lcd-e200v2.c |   15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

Loading...