Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9590 - Cowon D2 touchscreen driver registers wrong presses

Attached to Project: Rockbox
Opened by Francesco Rigoni (FranzD2) - Saturday, 29 November 2008, 22:19 GMT+2
Last edited by Rob Purchase (shotofadds) - Saturday, 26 September 2009, 22:58 GMT+2
Task Type Patches
Category Drivers
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Release 3.0
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Cowon D2 touchscreen driver registers wrong presses.
This task depends upon

Closed by  Rob Purchase (shotofadds)
Saturday, 26 September 2009, 22:58 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Obsolete as of r22843
Comment by Francesco Rigoni (FranzD2) - Saturday, 29 November 2008, 22:23 GMT+2
This patch solves the problem, it introduces an error compensation mechanism when reading values from the touchscreen and a busy wait on the "data ready" flag of the corresponding ADC instead of just writing ADCSTART and reading the value immediately.
Thgis patch applies to firmware/target/arm/tcc780x/cowond2/button-cowond2.c .
   rockbox-cowond2-button-touchscreen.patch (6.1 KiB) 
 firmware/target/arm/tcc780x/cowond2/button-cowond2.c |  177 ++++++++++---------
 1 file changed, 98 insertions(+), 79 deletions(-)

Comment by Maurus Cuelenaere (mcuelenaere) - Sunday, 30 November 2008, 13:56 GMT+2
TABs aren't compliant with the Rockbox guidelines ( http://svn.rockbox.org/viewvc.cgi/trunk/docs/CONTRIBUTING?view=markup ), you'll need to replace them with 4 spaces.
Comment by Francesco Rigoni (FranzD2) - Sunday, 30 November 2008, 18:21 GMT+2
Replaced all tabs with 4 spaces, sorry :)
   rockbox-cowond2-button-touchscreen.patch (7 KiB) 
 firmware/target/arm/tcc780x/cowond2/button-cowond2.c |  149 ++++++++++---------
 1 file changed, 81 insertions(+), 68 deletions(-)

Comment by Francesco Rigoni (FranzD2) - Sunday, 08 February 2009, 15:13 GMT+2
Ok, this patch include the calibration fix, hopefully that's the last one :)
   altTouchScreen_mode_calibration_fix.patch (7.8 KiB) 
 firmware/target/arm/tcc780x/cowond2/button-cowond2.c |  168 ++++++++++---------
 1 file changed, 93 insertions(+), 75 deletions(-)

Comment by Serg (Shad0w) - Tuesday, 12 May 2009, 13:40 GMT+2
I can't apply this patch.
Why?

:~/rockbox$ patch -p0 < altTouchScreen_mode_calibration_fix.patch
patching file firmware/target/arm/tcc780x/cowond2/button-cowond2.c
Hunk #3 succeeded at 29 with fuzz 2 (offset -1 lines).
Hunk #4 succeeded at 36 (offset -18 lines).
Hunk #5 succeeded at 52 (offset -18 lines).
Hunk #6 succeeded at 68 (offset -18 lines).
Hunk #7 FAILED at 92.
1 out of 7 hunks FAILED -- saving rejects to file firmware/target/arm/tcc780x/cowond2/button-cowond2.c.rej

P.S. SVN (revision 20916)
Comment by Andrew Beveridge (andrewthecoder) - Sunday, 17 May 2009, 03:40 GMT+2
The patch fails because that file has changed too much since the patch was made.
Have a look: http://svn.rockbox.org/viewvc.cgi/trunk/firmware/target/arm/tcc780x/cowond2/button-cowond2.c?view=log

Judging by the date of Franz's post above (8th February 2009), I suggest you try revision 18338 of that file.

Wait, by the looks of revision 20527, rob committed part of this patch to SVN already, so this patch is obsolete as far as I understand.

Loading...