Rockbox

Tasklist

FS#9606 - Pictureflow doesn't find albumart in /.rockbox/albumart/

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Friday, 05 December 2008, 02:19 GMT
Last edited by Jonas Häggqvist (rasher) - Friday, 12 December 2008, 21:29 GMT
Task Type Bugs
Category Plugins
Status Closed
Assigned To No-one
Operating System Sansa e200
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

Running Pictureflow, it does "Preparing album artwork" for a while, then exits displays two splashes: "No albums found" and "Could not create album art cache", I assume the latter is because of the former.

I do have plenty of albums and albumart on both internal disk and microsd card. All my albumart is in /.rockbox/albumart/ (available in several sizes, one of which is 100x100).

I suspect this is because id3.artist isn't set before calling search_albumart_files() in get_albumart_for_index_from_db(), so the search for albums in /.rockbox/albumart/ never runs since it needs to now the artist name. Ideally id3.albumartist should be set as well.

As a sidenote - shouldn't Pictureflow run even when no albumart is found?

Using r19324.
This task depends upon

Closed by  Jonas Häggqvist (rasher)
Friday, 12 December 2008, 21:29 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fix committed revision 19408 ( FS#9627  ).
Comment by Thomas Martitz (kugel.) - Friday, 05 December 2008, 13:14 GMT
AFAIK it basically only searches for cover*.bmp, yes.
Comment by Jonas Häggqvist (rasher) - Friday, 05 December 2008, 13:23 GMT
No, it searches for covers in the same place as the regular album art system as described on http://www.rockbox.org/twiki/bin/view/Main/AlbumArt#Where_To_Put_The_Images - from my reading of the code, it should certainly find <albumname>.bmp and <filename>.bmp for example.

Loading...