This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9617 - Keymaps for Plugins fuze
Attached to Project:
Rockbox
Opened by Frederick Full (fredddy) - Tuesday, 09 December 2008, 18:10 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Thursday, 08 January 2009, 21:34 GMT+2
Opened by Frederick Full (fredddy) - Tuesday, 09 December 2008, 18:10 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Thursday, 08 January 2009, 21:34 GMT+2
|
DetailsWell the plugins compile for me in the Simulator.
Hope this helps 
keymap_plugins_fuze.diff
(23.3 KiB)
apps/plugins/beatbox/beatbox.c | 3 ++- apps/plugins/bubbles.c | 2 +- apps/plugins/chessbox/chessbox_pgn.h | 17 +++++++++++++++++ apps/plugins/doom/i_video.c | 15 +++++++++++++++ apps/plugins/fireworks.c | 3 ++- apps/plugins/invadrox.c | 2 +- apps/plugins/jpeg/jpeg.h | 15 +++++++++++++++ apps/plugins/lamp.c | 8 ++++++++ apps/plugins/lib/pluginlib_actions.c | 11 +++++++---- apps/plugins/matrix.c | 2 +- apps/plugins/midi/midiplay.c | 2 +- apps/plugins/minesweeper.c | 13 +++++++++++++ apps/plugins/mpegplayer/mpegplayer.c | 2 +- apps/plugins/mpegplayer/mpeg_settings.c | 2 +- apps/plugins/pacbox/pacbox.h | 12 ++++++++++++ apps/plugins/pong.c | 12 ++++++++++-- apps/plugins/reversi/reversi-gui.h | 4 +++- apps/plugins/rockblox.c | 15 +++++++++++++-- apps/plugins/rockblox1d.c | 2 +- apps/plugins/rockboy/rockboy.c | 11 +++++++++++ apps/plugins/rockpaint.c | 13 +++++++++++++ apps/plugins/snake.c | 8 ++++++++ apps/plugins/snake2.c | 18 +++++++++++++++++- apps/plugins/solitaire.c | 24 ++++++++++++++++++++++-- apps/plugins/starfield.c | 3 ++- apps/plugins/sudoku/sudoku.h | 12 ++++++++++++ apps/plugins/superdom.c | 2 +- apps/plugins/zxbox/zxbox_keyb.c | 3 ++- apps/plugins/zxbox/keymaps.h | 4 +++- 29 files changed, 215 insertions(+), 25 deletions(-) |
This task depends upon
Closed by MichaelGiacomelli (saratoga)
Thursday, 08 January 2009, 21:34 GMT+2
Reason for closing: Accepted
Thursday, 08 January 2009, 21:34 GMT+2
Reason for closing: Accepted
i noticed that some keymaps are the same than C200, any reason you wouldn't rather use the e200 (which has a scrollwheel like the fuze, unlike the C200)?
i noticed also some lines like:
+#if CONFIG_KEYPAD != SANSA_E200_PAD | SANSA_FUZE_PAD
I'm not sure if simple '|' has a meaning for C preprocessor
It rather should be like:
+#if CONFIG_KEYPAD != SANSA_E200_PAD && CONFIG_KEYPAD != SANSA_FUZE_PAD
#if (CONFIG_KEYPAD != SANSA_E200_PAD) || (CONFIG_KEYPAD !=SANSA_FUZE_PAD)
I think it should work like this. In your way both SANSA_FUZE_PAD and SANSA_E200_PAD need to be false? but if one of them is true it would still compile without that code.
Your if is always true:
if CONFIG_KEYPAD == SANSA_E200_PAD the first part is false, but the 2nd is true (SANSA_E200_PAD != SANSA_FUZE_PAD) and so the whole if is true.
Hier is the new patch.
Did you try all the plugins by the way ? Some can look bad if they use bitmaps (I dont know if another target exists with the same screen size)
If some bitmaps need to be procuced, this can be done later and this patch should be committed what ever (bug someone to commit it).
thanks you !
I didn`t try all plugins on real hardware but I´ll do that now.
Build Errors:
- No keymap for mandelbrot plugin (Typo: rename dupe'd E200 keymap chunk to FUZE)
Keymap Errors:
- Bubbles keymap is wrong (missed a chunk to update)
Corrected patch attached.
I added some FIXMEs here and there, which I think should be fixed in other patches, and I have plans to do it myself soon, but I won't stop anyone else from beating me.