Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9626 - Reverse simulator background logic

Attached to Project: Rockbox
Opened by Jonas Häggqvist (rasher) - Friday, 12 December 2008, 21:15 GMT+2
Last edited by Jonas Häggqvist (rasher) - Thursday, 08 January 2009, 21:10 GMT+2
Task Type Patches
Category Simulator
Status Closed
Assigned To Jonas Häggqvist (rasher)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

This patch reverses the logic of the simulator background image, showing it by default and having a --nobackground switch. The rationale is that new users almost invariably have difficulty figuring out how to control the simulator when all they see is the display, whereas experienced users will know to turn it off if it really bothers them.

I'm putting this patch here mostly to get some discussion about whether to do this or not.
   simulator-background.diff (1.6 KiB) 
 uisdl.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Thursday, 08 January 2009, 21:10 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in revision 19726.
Comment by Dave Chapman (linuxstb) - Friday, 12 December 2008, 21:36 GMT+2
Gets my vote.
Comment by Paul Louden (Llorean) - Saturday, 13 December 2008, 03:35 GMT+2
Mine too.
Comment by Jonas Häggqvist (rasher) - Wednesday, 07 January 2009, 16:45 GMT+2
I'll commit this when I get the time (within a few days).

Loading...