- Status Closed
- Percent Complete
- Task Type Patches
- Category User Interface → Themes
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Daily build (which?)
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9643 - some themes.rockbox changes..
- display the targets in a table like on the other pages
- make rewrite rules etc. better to have better fall back than 404 on wrong urls
- add a upload link
Closed by mcuelenaere
2009-01-29 21:57
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-01-29 21:57
Reason for closing: Accepted
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
Thank you, parts of this are committed
now.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Ok, ignore the patch.
I'm trying to rewrite the whole themes.rockbox site.
My php skills are a bit rusty.. so it will take a week or two.
Post here if you have any suggestions.
Here is a first shot. (copy to localhost root)
Read the README.
Admin panel isn't very nice (doesn't refresh) but more powerful.
I will continue if I get some feedback.
http://www.student.tugraz.at/christoph.reiter/files/tmp/themes.rockbox.zip
I just took a short look at this.
A few remarks:
- Theme site itself looks nice. But i dont think the bug-report link under the Themes is good here. We probably dont want Bugreports about user-themes in the tracker.
- Admin-panel: I think this needs much more work to get it useable. It needes refreshes when you changes something. It should show the Theme when you click on the name and more. But it looks like a good start.
- I think one of the important things for this theme site is the automated checking when you upload a theme (maybe also rechecking in the admin interface). This should check all possible things (take a look at the upload/tools script in svn) and should also use checkwps to check the actual wps syntacs.
lets hope you continue you work, and we get a useable theme site fast
greets
New location: http://www.student.tugraz.at/christoph.reiter/files/rockbox/
Lots of exams ahead, so, not much time.
1) Started
2) It gets the job done for now… the only good solution I see is using "ajax" and that's not worth the effort.
3) Noted
Thanks for your review Dominik.
Hi,
not sure if I should add it here, but I did an update of Maurus Cuelenare's original theme site code.It works now for me for uploading and accepting themes. Some of the changes I made:
- added some more text in the index.php and put it in an additional file intro.php
- made links work in intro.php and added new links included for upload
- added new model handling in ini.php (model class)
- added some more automatic setup in ini.php
- made upload.php more generic
It can now be used to display and add themes.
What I would like to do: