Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9647 - Enhance tools/rockboxdev.sh to use environment variables for prefix, download, and build directories

Attached to Project: Rockbox
Opened by Eric Shattow (lucent) - Monday, 15 December 2008, 04:18 GMT+2
Last edited by Jonas Häggqvist (rasher) - Thursday, 08 January 2009, 21:02 GMT+2
Task Type Patches
Category Build environment
Status Closed
Assigned To Jonas Häggqvist (rasher)
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Uses if available:
RBDEV_PREFIX
RBDEV_DOWNLOAD
RBDEV_BUILD

Modifies language a bit to say that user should set these instead of editing rockboxdev.sh
   rockboxdev_env_vars.patch (1.6 KiB) 
 tools/rockboxdev.sh |   12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Jonas Häggqvist (rasher)
Thursday, 08 January 2009, 21:02 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  Committed in revision 19725, thank you.
Comment by Jonas Häggqvist (rasher) - Monday, 15 December 2008, 04:21 GMT+2
  • Field changed: Status (Unconfirmed → Assigned)
  • Field changed: Reported Version (Release 3.0 → Daily build (which?))
  • Field changed: Percent Complete (0% → 90%)
  • Task assigned to Jonas Häggqvist (rasher)
Is this fine for committing during the freeze? If so, I'll add it in a heartbeat. It's pretty obviously a good idea.
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 12:30 GMT+2
Just because we're already at rockboxdev.sh. I haven't looked so I just ask: Does it use predefined make default options like -j if the user has set it in his environment? (I remember that issue came up in -community recently).
Comment by Daniel Stenberg (bagder) - Monday, 15 December 2008, 12:57 GMT+2
Perhaps RBDEV_MAKEOPT would be suitable for that... What "predefined make default options" are you referring to?
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 14:47 GMT+2
Options like (and this one inparticular ;) ) "-j #"

make has some switches (see make --help), some of which might be enabled in one's environment, so that they're used at every make by default.
Comment by Daniel Stenberg (bagder) - Monday, 15 December 2008, 14:48 GMT+2
in what way are they "enabled in one's environment" ?
Comment by Thomas Martitz (kugel.) - Monday, 15 December 2008, 15:16 GMT+2
Someone mentioned it in #rockbox-community. The sad thing is that I have forgotten what he said :( But rasher was there too, he might remember, as he searched a way to let make automatically use -j instead of needing to hack rockboxdev.sh
Comment by Jonas Häggqvist (rasher) - Monday, 15 December 2008, 16:16 GMT+2
I believe it's MAKEOPTS, which you can set to whichever default options you want make to be invoked with. I don't think rockboxdev.sh needs to handle this. It should Just Work[tm].
Comment by Jonas Häggqvist (rasher) - Monday, 15 December 2008, 16:37 GMT+2
Nope, it's MAKEFLAGS.
Comment by Eric Shattow (lucent) - Tuesday, 16 December 2008, 04:53 GMT+2
make obeys MAKEFLAGS environment variable.

I.e. user may try: RB_PREFIX=/opt/rockboxdev ./rockboxdev.sh

...which is good and will work, but trying: MAKEFLAGS="-j" ./rockboxdev.sh

...may or may not work. It is not our responsibility. The user should be prepared with: export MAKEFLAGS="-j"

Patch stands as-is, any sponsor willing to commit?
Comment by Jonas Häggqvist (rasher) - Tuesday, 16 December 2008, 04:58 GMT+2
Still not sure if this is fine to commit during the freeze?
Comment by Jonas Häggqvist (rasher) - Wednesday, 07 January 2009, 16:44 GMT+2
I'll commit this when I get the time.

Loading...