Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9680 - empty .cfg file takes time to load

Attached to Project: Rockbox
Opened by Johannes Linke (Jaykay) - Friday, 19 December 2008, 18:54 GMT+2
Last edited by Jonathan Gordon (jdgordon) - Sunday, 21 December 2008, 14:15 GMT+2
Task Type Bugs
Category Settings
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

when i create a empty .cfg file in the themes-folder and select it with browse thems, the screen jitters(?) very short, then it says "loading..." for approx. 1 sec, then "loaded settings"...

but actally there is nothing to load, so why does it use so "much" time? the "loading...."-message should be not visible because the "settings loaded"-screen appears.

i know its not a real bug, but there could be something improved. maybe there are things checked which dont need to be checked, maybe all related settings are overwritten with the same settings or whatever. i dont know.
This task depends upon

Closed by  Jonathan Gordon (jdgordon)
Sunday, 21 December 2008, 14:15 GMT+2
Reason for closing:  Wont Fix
Additional comments about closing:  patch is in the comments if this annoys you too much
Comment by Johannes Linke (Jaykay) - Friday, 19 December 2008, 19:11 GMT+2
i forgot: sansa e280 + r19396.
Comment by Jonathan Gordon (jdgordon) - Sunday, 21 December 2008, 11:31 GMT+2
if it really annoys you, this patch will fix it. but I dont know if its worth putting in because how often would an empty .cfg be loaded?
   changes.patch (0.9 KiB) 
 apps/settings.c |   13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

Comment by Johannes Linke (Jaykay) - Sunday, 21 December 2008, 13:30 GMT+2
ok, now empty .cfg files or .cfg files with nonsense need approx 1/10 sec :)

but if you create a .cfg file with a single line in it, i.e. background color: 000000, it needs again the full 2s to jitter, show "loading...." and "settings loaded"....


but i admit its not a real bug. if nobody thinks it makes sense to fix the non-existent bug, it can be closed.
Comment by Jonathan Gordon (jdgordon) - Sunday, 21 December 2008, 13:35 GMT+2
there is no way to make it shorter... either we apply all the settings or we dont, so even a cfg with one line will still need to apply all settings
Comment by Johannes Linke (Jaykay) - Sunday, 21 December 2008, 13:42 GMT+2
rockbox could overwrite only the new settings..... but i think the result is not worth the work (...??, you know what i mean) so this can be closed.
Comment by Jonathan Gordon (jdgordon) - Sunday, 21 December 2008, 14:15 GMT+2
no, the setting loading and setting applying are done separately, and because of the way settings get applied this isnt possible.

Loading...