Rockbox

Tasklist

FS#9706 - Quickscreen: 4th item + some optimisations for remotes

Attached to Project: Rockbox
Opened by Thomas Martitz (kugel.) - Wednesday, 24 December 2008, 04:07 GMT
Last edited by Thomas Martitz (kugel.) - Saturday, 29 August 2009, 14:43 GMT
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Operating System All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

So, after the trouble with  FS#9661 , this patch fixes the confusion by adding a 4th item. The 4th item acts the same as the existing three.

It also tries to handle remotes, as it shows only three items (not the top one) on those, since the space and buttons are limited.

So, it keeps ACTION_QS_DOWNINV for remotes and recorder. Basically those screens that have this can only show 3 items.

It also rewrites the viewport preparation in the quickscreen a little bit (not too much), was a bit messy to get the 4th item properly working without.

TODO:
- Veryify that it works on remotes; I tried to test, it "looks" correct going by the sims, but those aren't very good to test buttons and such I noticed
- Handle Recorder so that he doesn't show the 4th item

Please test and leave some comments!
This task depends upon

Closed by  Thomas Martitz (kugel.)
Saturday, 29 August 2009, 14:43 GMT
Reason for closing:  Accepted
Additional comments about closing:  Committed in r22531.
Comment by Thomas Martitz (kugel.) - Wednesday, 24 December 2008, 04:28 GMT
Ooops, sorry, I missed that there's already a task about it ( FS#9675 ) :(
Comment by Thomas Martitz (kugel.) - Thursday, 13 August 2009, 14:56 GMT
sync

also added a mechanism to detect ACTION_QS_DOWN_INV in keymaps so that the top in favor of inverting the bottom one (needed for archos recorder and some remotes).
Comment by Jonathan Gordon (jdgordon) - Friday, 14 August 2009, 00:22 GMT
quick comments from my quick look on the bus...
I completely disagree with the top item handling.... by all means change the action name to TOP but having TOP and DOWNINV makes no sense... the logic should be if there is room for the top item, and it is set, then use TOP to change it.. otherwise do the downinv handling (which should be the same for all 4 directions)...

also, using a default which is target dependant is a bad idea from a support POV...
Comment by Thomas Martitz (kugel.) - Friday, 14 August 2009, 14:21 GMT
You never have both on one screen.

"by all means change the action name to TOP but having TOP and DOWNINV makes no sense" I don't understand. TOP is added, and DOWNINV still exists. If targets use DOWNINV, they won't have a TOP (or can't use it).

As you've written yourself in  FS#9675 , we can't just have TOP on all targets. This is the special handling you talked about.


The default val is probably questionable, indeed.
Comment by Jonathan Gordon (jdgordon) - Friday, 14 August 2009, 15:03 GMT
"You never have both on one screen."
exactly why there is no need for special handling... call it BUTTON_QS_UP if top doesnt work for you..
Comment by Thomas Martitz (kugel.) - Friday, 14 August 2009, 15:08 GMT
Is it just the name you have a problem with?
It can't be the same action since the action is searched for at detecting the special case (it searches for DOWNINV in the qs keymap array).
Comment by Jonathan Gordon (jdgordon) - Friday, 14 August 2009, 15:11 GMT
there is no need for that searching.... if there is room on the screen, and it is setup then do the up action.. otherwise do the downinv action....
Comment by Thomas Martitz (kugel.) - Friday, 14 August 2009, 15:12 GMT
It's not the space on the screen giving the limitation, it's the button maps.
Comment by Thomas Martitz (kugel.) - Monday, 24 August 2009, 14:34 GMT
Sync and update: I removed DOWNINV entirely as a IRC discussion showed that the recorder handling isn't needed.

I optimized displaying so far that special handling of small screens shouldn't be needed (with 64px, even a 13-14px font works cool).

Loading...