Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9744 - add missing sw tone control parameter on gigabeat s

Attached to Project: Rockbox
Opened by Sanggon, Lee (isanggon) - Friday, 02 January 2009, 09:46 GMT+2
Last edited by Torne Wuff (torne) - Tuesday, 13 April 2010, 23:49 GMT+2
Task Type Patches
Category Configuration
Status Closed
Assigned To No-one
Player Type Gigabeat F/X
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

Currently, there are sw tone coltrol option(bass/treble) on sound menu.
But sw tone control parameter for gigabeat s is missing, so sw tone control option don't work and just change volume.

This patch add missing sw tone control parameter on gigabeat s.


   add_sw_tonecontrols.diff (1.2 KiB) 
 _000_19606/firmware/export/config-gigabeat-s.h |    2 ++
 _000_19606/firmware/sound.c                    |    2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

This task depends upon

Closed by  Torne Wuff (torne)
Tuesday, 13 April 2010, 23:49 GMT+2
Reason for closing:  Fixed
Additional comments about closing:  r25641
Comment by Michael Sevakis (MikeS) - Friday, 02 April 2010, 08:37 GMT+2
A good interim measure. This thing has been a point of contention. Mostly because I wish that we'd use the hardware EQ to its fullest potential rather than using it in a crippled way. If something has hardware controls we use those instead of software ones, since the SW one were intended as a way to give tone control to lacking hardware. No way to handle this has been agreed upon. There's been some criticism that users might be confused by the presence of two EQs and the best I can come up with is to have five controls labelled as "tone".

Then again, having two menu items and no functionality is also confusing. :-\

Perhaps: bass, low-mid, mid, high-mid, treble?
Comment by Torne Wuff (torne) - Tuesday, 13 April 2010, 23:49 GMT+2
Until someone implements *some* kind of HW tone control, this will do :)

The change to sound.c is not needed, though; that list only needs to include codecs which have HW tone control but not HW prescale.

Loading...