Rockbox

Tasklist

FS#9805 - m4a metadata read or stored incorrectly

Attached to Project: Rockbox
Opened by Adam Rosi-Kessel (ajkessel) - Friday, 16 January 2009, 13:30 GMT
Last edited by Andree Buschmann (Buschel) - Sunday, 30 January 2011, 20:24 GMT
Task Type Bugs
Category ID3 / meta data
Status Closed
Assigned To No-one
Operating System iPod 5G
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

I have an album of m4a tracks. As far as I can tell with any other tool, they all have the identical "genre" tag -- "Country". Yet the album gets split up by RB 3.1 across several genres:

Cou
Coun
Country

Re-initializing the database doesn't change the result.

I can provide a sample of the tracks offline if necessary.
This task depends upon

Closed by  Andree Buschmann (Buschel)
Sunday, 30 January 2011, 20:24 GMT
Reason for closing:  Fixed
Additional comments about closing:  Fixed with r29174.
Comment by PaulJam (PaulJam) - Friday, 16 January 2009, 13:57 GMT
Hi, this seems to be a limitation of the metadata parser when there are very long tags present in the file.
See the forum discussion about this problem here:
http://forums.rockbox.org/index.php?topic=11657.0
Comment by Adam Rosi-Kessel (ajkessel) - Friday, 16 January 2009, 14:31 GMT
Thanks, that seems like a likely cause -- either the "comment" field (which MediaMonkey imports from the Amazon album description) and/or the album art. The thread you linked suggested a simple workaround of just increasing ID3V2_BUF_SIZE. Any reason not to do that at least for the iPod 5G builds? I would be happy to test such a build to confirm that it fixes my error.
Comment by Paul Louden (Llorean) - Friday, 16 January 2009, 16:10 GMT
Because you could also just strip the extraneous tags that we don't support anyway, like the embedded album art, rather than asking all users to give up a bit of *their* RAM so you can preserve tags Rockbox doesn't even support anyway.
Comment by PaulJam (PaulJam) - Friday, 16 January 2009, 16:33 GMT
According to the linked forum thread (post 4) the problem is with tags that rockbox actually supports, so stripping the extraneous tags won't solve this problem.
Comment by Adam Rosi-Kessel (ajkessel) - Friday, 16 January 2009, 16:37 GMT
Re Llorean -- many people who use automated tagging tools will have this problem. It isn't that I have some special predilection for extra information, I just pointed MediaMonkey at the folders and said "tag it." The result here can't possible be the correct behavior. The files work fine with iPod firmware, but then the user is told he needs to reprocess all his automatically tagged files so they display correctly in RB. However it is fixed, I can't see why RB shouldn't read in the track, genre, artist, and album correctly (assuming those tags don't exceed any limits, which I don't think they do for any of the cases we're talking about here.)
Comment by Thomas Martitz (kugel.) - Sunday, 25 January 2009, 23:57 GMT
You can just as easily use MediaMonkey to remove unneeded/unsupported (by Rockbox) tags. Select all files and edit for all files.
Comment by Adam Rosi-Kessel (ajkessel) - Monday, 26 January 2009, 00:02 GMT
But then you're asking the user to maintain two separate sets of music files (one on the computer, the other for the portable device). Is this a workaround hack or a proposed solution? I assume many users sync their music collection (or some subset thereof) from their computer to the portable device and vice-versa. If the goal is for Rockbox to usable by non-sophisticated people (?), the solution can't possibly be to tell them they need to edit the metadata on all of the files that play fine on iPod/iTunes and other desktop sofware.
Comment by Thomas Martitz (kugel.) - Monday, 26 January 2009, 00:07 GMT
See, we have very limited RAM on Mp3 players (being highly embedded systems). Additionally, Rockbox runs on many players, some of which have much lower RAM than your iPod. And we want to support all equally, getting more out of it (especially battery runtime).

Saving RAM where possible is essential for the battery runtime. So please do not compare Rockbox with the possibilities of a desktop music player, which don't need to worry about RAM and stuff. And, well, the iPod has pretty much RAM, so Apple probably didn't care about efficient RAM usage either.
Comment by Adam Rosi-Kessel (ajkessel) - Monday, 26 January 2009, 02:43 GMT
I'm just trying to compare an iPod running RB with an iPod running the Apple firmware -- since RB is built for each platform, why can't it at least work properly on the iPod regarding this metadata issue? Or is there a better fix that doesn't require more RAM use? It seems like the issue here is the wrong metadata is being stored in RAM; the tags we see (artist, album, genre, track name, track number) are not overloading the buffer.

Loading...