This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9828 - Quickscreen: implement cancelling
Attached to Project:
Rockbox
Opened by Thomas Martitz (kugel.) - Sunday, 25 January 2009, 19:55 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 16:37 GMT+2
Opened by Thomas Martitz (kugel.) - Sunday, 25 January 2009, 19:55 GMT+2
Last edited by Thomas Martitz (kugel.) - Thursday, 22 December 2011, 16:37 GMT+2
|
DetailsThis patch implements cancelling changes in the quickscreen. If the changes are discarded, a splash will appear for some 250ms (HZ/4).
The side effect: For most targets, the button that exited the quickscreen will now cancel. So, in order to save the settings, the usual ok/select button must be used (except for buttons which are used to change options, like right, on some targets) The changes to the keymap are to make sure, that the buttons which changes the options don't also act as ok button. E.g. if the usual select is mapped to right (in addition to select), the quickscreen must make sure that right is remapped to not act as ok button. 
quickscreen-cancel.diff
(18.9 KiB)
apps/gui/quickscreen.c | 31 ++++++++++++++++++++++++++----- apps/keymaps/keymap-sa9200.c | 2 ++ apps/keymaps/keymap-m200.c | 1 + apps/keymaps/keymap-m3.c | 2 ++ apps/keymaps/keymap-touchscreen.c | 4 +++- apps/keymaps/keymap-creativezv.c | 2 ++ apps/keymaps/keymap-h1x0_h3x0.c | 2 ++ apps/keymaps/keymap-ifp7xx.c | 2 ++ apps/keymaps/keymap-clip.c | 1 + apps/keymaps/keymap-iaudio67.c | 3 ++- apps/keymaps/keymap-h10.c | 2 ++ apps/keymaps/keymap-av300.c | 2 ++ apps/keymaps/keymap-ipod.c | 2 ++ apps/keymaps/keymap-x5.c | 2 ++ apps/keymaps/keymap-creativezvm.c | 2 ++ apps/keymaps/keymap-mr100.c | 2 ++ apps/keymaps/keymap-logikdax.c | 3 ++- apps/keymaps/keymap-gigabeat.c | 2 ++ apps/keymaps/keymap-gigabeat-s.c | 2 ++ apps/keymaps/keymap-c100.c | 3 ++- apps/keymaps/keymap-c200.c | 1 + apps/keymaps/keymap-recorder.c | 2 ++ apps/keymaps/keymap-e200.c | 1 + apps/keymaps/keymap-meizu-m6sl.c | 2 ++ apps/keymaps/keymap-hdd1630.c | 2 ++ apps/keymaps/keymap-fuze.c | 1 + 26 files changed, 72 insertions(+), 9 deletions(-) |
This task depends upon
Closed by Thomas Martitz (kugel.)
Thursday, 22 December 2011, 16:37 GMT+2
Reason for closing: Out of Date
Thursday, 22 December 2011, 16:37 GMT+2
Reason for closing: Out of Date
Also, we would like to be able to put a .cfg selector in the screen whcih this patch would bassically kill
Edit (re cfg selector): another "possibly somewhere in the future added feature, which isn't even yet decided how it's going to be implemented". Anyway, if the cfg selector would just open the filebrowser to some pre-defined cfg folder (which is probably also the easiest way to do it), this wouldn't break it.
I left the int for now, as I didn't encounter any problems (I'm using 64bit sim).
Some more notes why I think this patch is useful:
Canceling settings is something I really like, and I use that often. I find this incredibly useful with settings which are applied by "hovering" above them (i.e. which take effect before you hit confirm). I'd like to have the quickscreen do that as well.
I like consistency. Virtually almost every setting can be cancelled, and I don't see a reason why the quickscreen should be an exception.
The quickscreen is still live, this patch doesn't change any of its liveness. Toggling through the settings will take effect immediately, just as before.
edit: correct diff this time.