Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9855 - Text viewer plugin: Title and page number are displayed

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Sunday, 01 February 2009, 04:18 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:21 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

For text viewer plugin, title (filename) and page number are displayed.

The display and non-display of title and page number can be set on a set screen.

Attention:
The operation of "show bottom page" (RIGHT button) slows by this change.
   viewer_page.patch (13 KiB) 
 b/apps/plugins/viewer.c |  228 +++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 196 insertions(+), 32 deletions(-)

This task depends upon

Closed by  Yoshihisa Uchida (Uchida)
Wednesday, 17 March 2010, 13:21 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  patch commits and manual updates.
Comment by Yoshihisa Uchida (Uchida) - Sunday, 01 February 2009, 04:37 GMT+2
Additional comment.

Because the item preserved in a bookmark info increased, all old bookmarks are deleted.
Then the text file is displayed starts first page after this patch file is applied.
Comment by Yoshihisa Uchida (Uchida) - Tuesday, 03 February 2009, 11:54 GMT+2
My patch file is corrected.

changes:
The following bug fix.
- When scroll mode = LINE and display page is top page, if we operare scroll up, then current line number is invalid.
- At scroll mode = LINE, and scroll mode = PAGE, the display of the final page is different.
   viewer_page_2.patch (13.6 KiB) 
 b/apps/plugins/viewer.c |  240 +++++++++++++++++++++++++++++++++++++++++-------
 1 file changed, 206 insertions(+), 34 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 07 February 2009, 08:02 GMT+2
Patch updates.

changes:
- When the setting was changed, the page number was calculated again.
- Status bar was able to be displayed in the header.
   viewer_page_3.patch (17.1 KiB) 
 b/apps/plugins/viewer.c |  343 +++++++++++++++++++++++++++++++++++++++++++-----
 1 file changed, 308 insertions(+), 35 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 11 February 2009, 03:37 GMT+2
Patch updates.

changes:
- When scroll mode = LINE, correction of problem to which text is not correctly displayed when scroll up/scroll down on the last page.
- It is corrected that the page number is not calculated again when the preference is not changed on the setting screen.
   viewer_page_4.patch (18.9 KiB) 
 b/apps/plugins/viewer.c |  384 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 317 insertions(+), 67 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 11 February 2009, 04:52 GMT+2
Oops!! I uploaded old patch file, sorry.
I upload new patch file again.
   viewer_page_5.patch (18.6 KiB) 
 b/apps/plugins/viewer.c |  381 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 314 insertions(+), 67 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 17 June 2009, 11:07 GMT+2
sync svn. 21316
   viewer_page_6.patch (19 KiB) 
 b/apps/plugins/viewer.c |  384 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 316 insertions(+), 68 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Friday, 19 February 2010, 12:34 GMT+2
sync r24770
   viewer_page_7.patch (20.1 KiB) 
 b/apps/plugins/viewer.c |  413 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 344 insertions(+), 69 deletions(-)

Loading...