Rockbox

  • Status Unconfirmed
  • Percent Complete
    0%
  • Task Type Patches
  • Category Plugins
  • Assigned To No-one
  • Operating System All players
  • Severity Low
  • Priority Very Low
  • Reported Version Daily build (which?)
  • Due in Version Undecided
  • Due Date Undecided
  • Votes
  • Private
Attached to Project: Rockbox
Opened by siber_cat - 2009-02-01

FS#9856 - More robust patchset.cfg reader for midi player

I was reading http://forums.rockbox.org/index.php?topic=17079.0 and thought I’d take a swing at it. So far, I have added (potentially shaky?) support for the ‘#’ comments in the file posted, allowing both Windows and Linux line ending formats, and longer filename support.
Still having problems with the white space after each entry, and detecting or assuming the presence of the file extension.

nls commented on 2009-02-01 10:40

Looks good, one question though, why do you define your own FILE_NAME_LIMIT instead of using MAX_PATH ?

I've applied the patch to r20001 however the midi plugin freezes while loading the instruments (blacklight still reacts but leaving the plugin fails).
Attached is the same patch but it is using MAX_PATH instead of FILE_NAME_LIMIT (same behaviour).

Loading...

Available keyboard shortcuts

Tasklist

Task Details

Task Editing