- Status Closed
- Percent Complete
- Task Type Patches
- Category Drivers
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Version 3.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
Attached to Project: Rockbox
Opened by fruchtschwert - 2009-02-01
Last edited by bluebrother - 2011-06-05
Opened by fruchtschwert - 2009-02-01
Last edited by bluebrother - 2011-06-05
FS#9857 - Patch for switching off the buttonlight while the Select-Button is pressed: nice visual feedback
This patch is part of a new feature request.
I tried it out with my Sansa e200 which has an illuminated scrollring.
Now my proposal:
When the user is pressing the Select-Button (for example to choose an entry from the menu) the button-driver should turn off the light of the scrollring as long as the button is pressed.
It then appears as if the buttonlight is kind of “flashing” for a moment.
This is a nice visual feedback for pressing the button.
Attached you can find the patch for Rockbox 3.1, which I implemented for my Sansa e200.
The only file which is changed is “firmware/drivers/button.c”.
The code should work for all players (of course only makes sense if a buttonlight is available).
Closed by bluebrother
2011-06-05 09:37
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2011-06-05 09:37
Reason for closing: Out of Date
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
no interest in the last 2 years, out of
date.
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
here is the patch file ..
You can find the forum discussion here:
http://forums.rockbox.org/index.php?topic=20441.0
I applied your patch, and I think it’s great. But here’s the thing:
When you make button backlight off, your patch isn’t gonna work!