Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9875 - [Cowon D2] Enable Track Skipping on Hold Mode

Attached to Project: Rockbox
Opened by Nicolás F. (3amsleep) - Saturday, 07 February 2009, 07:49 GMT+2
Last edited by Rob Purchase (shotofadds) - Wednesday, 21 October 2009, 23:24 GMT+2
Task Type Patches
Category User Interface
Status Closed
Assigned To No-one
Player Type Another
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

I made a little patch that enables the user to change the tracks while on hold mode by pressing the minus or plus buttons.

Personally I think this feature comes really handy when you're on the street/bus/metro, since you don't have to get the D2 out of your pocket, thus keeping it safe =).
   altHold_Mode.patch (1.1 KiB) 
 firmware/target/arm/tcc780x/cowond2/button-cowond2.c |   20 +++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)

This task depends upon

Closed by  Rob Purchase (shotofadds)
Wednesday, 21 October 2009, 23:24 GMT+2
Reason for closing:  Out of Date
Additional comments about closing:  Superceded by fs#10683
Comment by Rob Purchase (shotofadds) - Saturday, 14 February 2009, 01:10 GMT+2
Yes, it's certainly a nice useful feature from the Cowon firmware that's currently missing in Rockbox. There is a slight issue with this patch though, which is that it always maps HOLD+PLUS to MIDRIGHT (etc), so some unintended actions might occur when using screens other than the Now Playing screen.

A neater way to implement this might be to define two new button codes BUTTON_HOLD_PLUS and BUTTON_PLUS_MINUS, and map those to ACTION_WPS_SKIPNEXT (etc) in the WPS section of keymap-cowond2.c. Try it and see...
Comment by Rob Purchase (shotofadds) - Saturday, 14 February 2009, 01:14 GMT+2
I can't type tonight, clearly I meant BUTTON_HOLD_PLUS and BUTTON_HOLD_MINUS... ;-)
Comment by Rob Purchase (shotofadds) - Wednesday, 18 February 2009, 23:19 GMT+2
Here's a patch that works in the way I suggested. It "works for me", but I won't commit it yet because the backlight fading behaviour doesn't seem correct when using this function. I'll look into it...
   hold_skip.diff (1.8 KiB) 
 apps/keymaps/keymap-cowond2.c                        |    3 +++
 firmware/target/arm/tcc780x/cowond2/button-cowond2.c |   12 ++++++++++--
 firmware/target/arm/tcc780x/cowond2/button-target.h  |    6 +++++-
 3 files changed, 18 insertions(+), 3 deletions(-)

Comment by Johannes Boy (joboy) - Friday, 21 August 2009, 10:52 GMT+2
There are a bunch of customized configurations over at the iaudiophile forum: http://iaudiophile.net/forums/showthread.php?t=28467
That post includes patches and built binaries, I have no idea which version, though.
Plus, some configs mess around with a lot of files, not only the keymap.
Quoting from the config 5, which I use:
"When in hold mode;
pressing MINUS decreases volume by one,
pressing PLUS increases volume by one,
pressing MENU switches between Play and Pause,
holding MINUS skips back a track,
holding PLUS skips forward a track,
holding MENU advances to the next folder."
IMO the most usable and pretty close to the cowon firmware I believe.

Loading...