- Status Closed
- Percent Complete
- Task Type Patches
- Category Plugins
- Assigned To No-one
- Operating System All players
- Severity Low
- Priority Very Low
- Reported Version Version 3.1
- Due in Version Undecided
-
Due Date
Undecided
- Votes
- Private
FS#9878 - Don't let the lamp plugin compile for players without backlight
This patch lets the compiler to issue a compile error when the lamp plugin is built for a player without the backlight feature.
Without this patch, the whole file is #ifdef’ed out so that there will be no plugin entry point. The patch makes the compile process fail with a describing error message.
Closed by nls
2009-03-28 17:00
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
2009-03-28 17:00
Reason for closing: Fixed
Additional comments about closing: Warning: Undefined array key "typography" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 371 Warning: Undefined array key "camelcase" in /home/rockbox/flyspray/plugins/dokuwiki/inc/parserutils.php on line 407
deleted the check altogether in r
20563
Loading...
Available keyboard shortcuts
- Alt + ⇧ Shift + l Login Dialog / Logout
- Alt + ⇧ Shift + a Add new task
- Alt + ⇧ Shift + m My searches
- Alt + ⇧ Shift + t focus taskid search
Tasklist
- o open selected task
- j move cursor down
- k move cursor up
Task Details
- n Next task
- p Previous task
- Alt + ⇧ Shift + e ↵ Enter Edit this task
- Alt + ⇧ Shift + w watch task
- Alt + ⇧ Shift + y Close Task
Task Editing
- Alt + ⇧ Shift + s save task
Surely it would make more sense to not compile it at all (by ifdeffinng it out of apps/plugins/SOURCES)?
It’s ifdeff’ed there. This is just an additional security check.
I don’t understand. lamp.c should never be processed…why the “additional security check”?
Yes, lamp.c is ifdeffed out in the SOURCES file. So it might be better to remove the check in the .c file itself. But it contained one. This patch just makes the check better. But, as I said, it could/should be removed alltogether.