Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9883 - Correct the function for forcing the backlight ON and add a func to force it OFF

Attached to Project: Rockbox
Opened by Alexander Levin (fml2) - Sunday, 08 February 2009, 13:08 GMT+2
Last edited by Teruaki Kawashima (teru) - Monday, 24 January 2011, 13:40 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The implementation of the force_backlight_on was not correct IMO. If the current setting value is OFF then calling the function wouldn't have any effect.
   bl_onoff_helper.patch (3.9 KiB) 
 apps/plugins/lib/helper.c |   73 +++++++++++++++++++++++++++++++++++-----------
 apps/plugins/lib/helper.h |    3 +
 2 files changed, 60 insertions(+), 16 deletions(-)

This task depends upon

Closed by  Teruaki Kawashima (teru)
Monday, 24 January 2011, 13:40 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  bl_helper.diff is committed as r29128.
Comment by Thomas Martitz (kugel.) - Tuesday, 10 February 2009, 18:38 GMT+2
Not sure if this is really a bug.

This would hit only targets where the screen is readable without backlight. And if the user decided against backlight at all, it shouldn't be turned off, not even forced, I suppose. On the other targets (where you need backlight to read the screen), disabling backlight at all isn't a valuable option anyway (except for blind users maybe) and thus this wouldn't change anything.
Comment by Alexander Levin (fml2) - Tuesday, 10 February 2009, 19:45 GMT+2
IMO the whole point of the force functions is to override the current settings whatever they are. My view is confirmed by the fact that the lamp plugin does not work if the BL setting is set to OFF (try it on e.g. H120).
Comment by Alexander Levin (fml2) - Wednesday, 11 February 2009, 08:07 GMT+2
For possible readers: See also discussion in IRC starting at http://www.rockbox.org/irc/log-20090210#21:15:09 and ending ~22:15.
Comment by Steve Bavin (pondlife) - Wednesday, 11 February 2009, 09:59 GMT+2
I like the idea of renaming it to ignore_backlight_timeout() - i.e. making a "timed out" backlight be in the on state, not the off state. If the user configures the backlight off always, or off on hold, then that is still respected.

Personally, on my H300, I configure backlight on a 20s timeout, plus off if HOLD is on. I'd want it to stay on during the plugin, but turn off when I enable the hold switch (and back on again when I disable it, of course).
Comment by Linton Dawe (Linton) - Saturday, 18 July 2009, 14:01 GMT+2
buttonlight_force_on also does nothing when the buttonlight timeout is set to Off, causing the buttonlight functionality of the lamp plugin to fail. The same changes (if x != newvalue instead of if x > 0) could be applied to this function as well. I have the buttonlight switched off on my Sansa because I find it too bright - but when running lamp, bright lights are exactly what I want!
Comment by Teruaki Kawashima (teru) - Thursday, 20 January 2011, 15:28 GMT+2
i think this change is reasonable.
* rename backlight_force_on to backlight_ignore_timeout to make the name suit what the function does.
* add function backlight_force_on that actually forces baclight to turn on and use this in lamp plugin.
in the other words, nothing is changed except lamp plugin always turn on the backlight.

i'd like to commit this in few days if no one object to.
if there are other plugins which make sense to force backlight on, then we can change them later.
   bl_helper.diff (25.3 KiB) 
 apps/plugins/test_grey.c               |    4 ++--
 apps/plugins/plasma.c                  |    4 ++--
 apps/plugins/oscilloscope.c            |    4 ++--
 apps/plugins/video.c                   |    4 ++--
 apps/plugins/starfield.c               |    4 ++--
 apps/plugins/fire.c                    |    4 ++--
 apps/plugins/rocklife.c                |    4 ++--
 apps/plugins/greyscale.c               |    4 ++--
 apps/plugins/lib/helper.c              |   26 +++++++++++++++++++++++++-
 apps/plugins/lib/helper.h              |    3 +++
 apps/plugins/test_disk.c               |    4 ++--
 apps/plugins/spacerocks.c              |    4 ++--
 apps/plugins/brickmania.c              |    4 ++--
 apps/plugins/pitch_detector.c          |    4 ++--
 apps/plugins/mazezam.c                 |    4 ++--
 apps/plugins/resistor.c                |    6 +++---
 apps/plugins/demystify.c               |    4 ++--
 apps/plugins/fft/fft.c                 |    2 +-
 apps/plugins/xobox.c                   |    4 ++--
 apps/plugins/pong.c                    |    2 +-
 apps/plugins/maze.c                    |    4 ++--
 apps/plugins/fireworks.c               |    4 ++--
 apps/plugins/rockblox.c                |    8 ++++----
 apps/plugins/mpegplayer/mpegplayer.c   |    3 +--
 apps/plugins/doom/rockdoom.c           |    2 +-
 apps/plugins/imageviewer/imageviewer.c |    8 ++++----
 apps/plugins/rockboy/menu.c            |    2 +-
 apps/plugins/rockboy/rockboy.c         |    2 +-
 apps/plugins/lrcplayer.c               |    6 +++---
 apps/plugins/chopper.c                 |    4 ++--
 apps/plugins/pictureflow/pictureflow.c |    4 ++--
 apps/plugins/test_gfx.c                |    2 +-
 apps/plugins/test_fps.c                |    4 ++--
 apps/plugins/wormlet.c                 |    4 ++--
 apps/plugins/invadrox.c                |    4 ++--
 apps/plugins/pdbox/pdbox.c             |    2 +-
 apps/plugins/credits.c                 |    4 ++--
 37 files changed, 96 insertions(+), 70 deletions(-)

Loading...