Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9892 - Text viewer plugin: Patch by which user can set bookmarks freely.

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Wednesday, 11 February 2009, 05:59 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:22 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

We cannot set the bookmark freely. (The page read at the end is only automatically saved.)

By applying this patch, we can set 9 bookmarks or less at each file.


Because the bookmark file (viewer_bookmarks.dat) is incompatible with the one used now.
Then the text file is displayed starts first page after this patch file is applied.

About patch apply:
At first, please applied the patch file of  FS#9855  (http://www.rockbox.org/tracker/task/9855?getfile=18542).
After, please applied this task's patch file.





   viewer_bookmark.patch (30.2 KiB) 
 b/apps/plugins/viewer.c |  767 ++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 620 insertions(+), 147 deletions(-)

This task depends upon

Closed by  Yoshihisa Uchida (Uchida)
Wednesday, 17 March 2010, 13:22 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  patch commits and manual updates.
Comment by Yoshihisa Uchida (Uchida) - Thursday, 05 March 2009, 14:15 GMT+2
The patch file updates.

Changes:
- When the scroll mode is "PAGE", The text is not displayed from the first line on the page when the bookmark is selected.
   viewer_bookmark_2.patch (30.8 KiB) 
 b/apps/plugins/viewer.c |  773 ++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 626 insertions(+), 147 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 17 June 2009, 11:08 GMT+2
svnc r21316
   viewer_bookmark_3.patch (30.8 KiB) 
 b/apps/plugins/viewer.c |  773 ++++++++++++++++++++++++++++++++++++++----------
 1 file changed, 626 insertions(+), 147 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 20 February 2010, 03:46 GMT+2
sync r24782
   viewer_bookmark_4.patch (31.7 KiB) 
 b/apps/plugins/viewer.c |  764 +++++++++++++++++++++++++++++++++++++++---------
 1 file changed, 624 insertions(+), 140 deletions(-)

Loading...