Rockbox

This is the bug/patch tracker for Rockbox. Click here for more information.

Quick links: Bugs · Patches · Rockbox frontpage

Tasklist

FS#9902 - Text viewer plugin: Patch that jumps to registered bookmarks

Attached to Project: Rockbox
Opened by Yoshihisa Uchida (Uchida) - Friday, 13 February 2009, 11:40 GMT+2
Last edited by Yoshihisa Uchida (Uchida) - Wednesday, 17 March 2010, 13:24 GMT+2
Task Type Patches
Category Plugins
Status Closed
Assigned To No-one
Player Type All players
Severity Low
Priority Normal
Reported Version Daily build (which?)
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Private No

Details

The menu that can jump to the position of the selected bookmark is added to the menu screen.

Please appropriate the patch in order of  FS#9855 ,  FS#9892 ,  FS#9893 ,  FS#9898  and this task's patch (viewer_select_bookmark.patch).

If you want reduce the number of patches that should be applied,
then you should apply FS9899 (this task is closed) and viewer_select_bookmark_fs9899.patch.


   viewer_select_bookmark.patch (4.7 KiB) 
 b/apps/plugins/viewer.c |   79 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 55 insertions(+), 24 deletions(-)

   viewer_select_bookmark_fs9899.patch (4.7 KiB) 
 b/apps/plugins/viewer.c |   79 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 55 insertions(+), 24 deletions(-)

This task depends upon

Closed by  Yoshihisa Uchida (Uchida)
Wednesday, 17 March 2010, 13:24 GMT+2
Reason for closing:  Accepted
Additional comments about closing:  patch commits and manual updates.
Comment by Yoshihisa Uchida (Uchida) - Friday, 13 February 2009, 12:29 GMT+2
Sorry, I send old patch file.

I send new patch.
   viewer_select_bookmark_2.patch (4.7 KiB) 
 b/apps/plugins/viewer.c |   79 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 55 insertions(+), 24 deletions(-)

   viewer_select_bookmark_fs9899_2.patch (4.7 KiB) 
 b/apps/plugins/viewer.c |   79 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 55 insertions(+), 24 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 21 February 2009, 04:16 GMT+2
sync patch (bucause  FS#9898  updates)
   viewer_select_bookmark_3.patch (4.7 KiB) 
 b/apps/plugins/viewer.c |   79 +++++++++++++++++++++++++++++++++---------------
 1 file changed, 55 insertions(+), 24 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Thursday, 05 March 2009, 14:31 GMT+2
The patch file updates.

Changes:
- I correct that the page of the selected bookmark might not be displayed.
   viewer_select_bookmark_4.patch (6 KiB) 
 b/apps/plugins/viewer.c |  115 ++++++++++++++++++++++++++++++++++--------------
 1 file changed, 82 insertions(+), 33 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Wednesday, 17 June 2009, 11:11 GMT+2
sync r21316
   viewer_select_bookmark_5.patch (6.2 KiB) 
 b/apps/plugins/viewer.c |  117 ++++++++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 34 deletions(-)

Comment by Yoshihisa Uchida (Uchida) - Saturday, 20 February 2010, 06:56 GMT+2
sync r24782
   viewer_select_bookmark_6.patch (6.2 KiB) 
 b/apps/plugins/viewer.c |  117 ++++++++++++++++++++++++++++++++++--------------
 1 file changed, 83 insertions(+), 34 deletions(-)

Loading...