This is the bug/patch tracker for Rockbox. Click here for more information.
Quick links: Bugs · Patches · Rockbox frontpage
FS#9959 - Remove delay code in e200v2 button driver
Attached to Project:
Rockbox
Opened by Jack Halpin (FlynDice) - Friday, 27 February 2009, 01:19 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Friday, 10 April 2009, 17:20 GMT+2
Opened by Jack Halpin (FlynDice) - Friday, 27 February 2009, 01:19 GMT+2
Last edited by MichaelGiacomelli (saratoga) - Friday, 10 April 2009, 17:20 GMT+2
|
DetailsThis patch removes the delay before reading dbop_din and reduces the delay before reading gpio for the buttons on the e200v2. I also added some comments in the read_dbop function to make it easier to follow what is happening. I have not noted any ill effect after removing the dbop delay. The gpio delay is reqired to be at least 1 or the buttons do not work correctly. I have set it at 2 and have noticed no problems after several days of use.
button-e200v2.patch
(4.4 KiB)
firmware/target/arm/as3525/sansa-e200v2/button-e200v2.c | 58 +++++++--------- 1 file changed, 28 insertions(+), 30 deletions(-) |
This task depends upon
Closed by MichaelGiacomelli (saratoga)
Friday, 10 April 2009, 17:20 GMT+2
Reason for closing: Accepted
Additional comments about closing: Accepted in r20676.
Friday, 10 April 2009, 17:20 GMT+2
Reason for closing: Accepted
Additional comments about closing: Accepted in r20676.
Comment by MichaelGiacomelli (saratoga) -
Friday, 10 April 2009, 03:55 GMT+2
This looks good to me. Would you like me to commit it?
Comment by Jack Halpin (FlynDice) -
Friday, 10 April 2009, 15:22 GMT+2
Please do!