Rockbox

Tasklist

FS#9959 - Remove delay code in e200v2 button driver

Attached to Project: Rockbox
Opened by Jack Halpin (FlynDice) - Friday, 27 February 2009, 00:19 GMT
Last edited by MichaelGiacomelli (saratoga) - Friday, 10 April 2009, 15:20 GMT
Task Type Patches
Category Operating System/Drivers
Status Closed
Assigned To No-one
Operating System Another
Severity Low
Priority Normal
Reported Version Version 3.1
Due in Version Undecided
Due Date Undecided
Percent Complete 100%
Votes 0
Private No

Details

This patch removes the delay before reading dbop_din and reduces the delay before reading gpio for the buttons on the e200v2. I also added some comments in the read_dbop function to make it easier to follow what is happening. I have not noted any ill effect after removing the dbop delay. The gpio delay is reqired to be at least 1 or the buttons do not work correctly. I have set it at 2 and have noticed no problems after several days of use.
This task depends upon

Closed by  MichaelGiacomelli (saratoga)
Friday, 10 April 2009, 15:20 GMT
Reason for closing:  Accepted
Additional comments about closing:  Accepted in r20676.
Comment by MichaelGiacomelli (saratoga) - Friday, 10 April 2009, 01:55 GMT
This looks good to me. Would you like me to commit it?
Comment by Jack Halpin (FlynDice) - Friday, 10 April 2009, 13:22 GMT
Please do!

Loading...